From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CE8CC4332F for ; Mon, 17 Oct 2022 21:30:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B5B5D84F65; Mon, 17 Oct 2022 23:29:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="OqJjLocu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1557B84F40; Mon, 17 Oct 2022 23:29:20 +0200 (CEST) Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4EFBC84E6B for ; Mon, 17 Oct 2022 23:29:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa33.google.com with SMTP id u204so5989325vkb.13 for ; Mon, 17 Oct 2022 14:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:references:in-reply-to:from:sender :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sJQJ/6p58LGCqkP50tfolLa/AhlW4JBMXeeSLTeurrI=; b=OqJjLocujXl6hve4M71OopIdKVqIQRfb7+dxtW4H4YuFiV9N1cEY7UQKo+UefF03Vc TcXcg4FEh/O69eDTws1zd8+ass8XaJZ9UJA9XJBE+2P/C3rilQcRqfNlURlQo+5hvsIp gfEQrgwb/AlHPBe+Wv/HGhpvc/3Qd0Vogiwcg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:references:in-reply-to:from:sender :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sJQJ/6p58LGCqkP50tfolLa/AhlW4JBMXeeSLTeurrI=; b=BOgR4U5B44fkD6YPXG/fOgKdmFZvdCoF8zzLDxpNGG8WcQaM/PV7OYKh5KX1sIs4j7 z8Glcl7ozs2EHQaMKqYkR6inaQd1nk739jNbr1iF5egXljwxOFMey+ttzm85Yf3+UNUR Qxl2IgDvfpUA7eL2Er1OuU6kVdBhxZyf35FdRt30YfKR6mxYPUjSqxKmXeFV/07HPBSr JmmR+U0bl1Jb7Ldw62VIMue4QHlIpEoBbb8Cqy5dHcdAX7H/Ngr8iE3ogFXA76HYOwaS EvMRePsic4qk7Sz2JQ3Zf/VzAApSjUJ7gdUlgfZMusguJAbNfIxPyWpU1Kf9mFQymByw p8eA== X-Gm-Message-State: ACrzQf34y9sQ9UYXUSz7utyC9Y1gpMxq3gPE8wxGRIOXFPRNTNoxJU2Z dZn+vpa1mRfgL0IlYkTN/aW+9fI+zRZEu5psMG6QaA== X-Google-Smtp-Source: AMsMyM5bNeL80PuIYOCVzaVxOJ9mn94sCMHU/gvPZGDUnS7J8lbajHHZ4XzpxaG6S7H+XBONI/N2WoRZQQUsDQ+hHZY= X-Received: by 2002:a1f:34d8:0:b0:377:142f:3e2f with SMTP id b207-20020a1f34d8000000b00377142f3e2fmr5230095vka.27.1666042155862; Mon, 17 Oct 2022 14:29:15 -0700 (PDT) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Mon, 17 Oct 2022 14:29:14 -0700 MIME-Version: 1.0 From: Simon Glass In-Reply-To: <003231fc79241ed075dfefe8a4eedebd23374294.1665604425.git.msuchanek@suse.de> References: <003231fc79241ed075dfefe8a4eedebd23374294.1665604425.git.msuchanek@suse.de> Date: Mon, 17 Oct 2022 14:29:14 -0700 X-Google-Sender-Auth: wSEFMBnsZbWFwTC9vFLGHaiGI7Y Message-ID: Subject: Re: [PATCH v6 12/20] dm: blk: Do not use uclass_next_device_err To: Michal Suchanek Cc: Simon Glass , Heinrich Schuchardt , AKASHI Takahiro , u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean blk_first_device_err/blk_next_device_err uses uclass_first_device_err/uclass_next_device_err for device iteration. Although the function names superficially match the return value from uclass_first_device_err/uclass_next_device_err is never used meaningfully, and uclass_first_device/uclass_next_device works equally well for this purpose. In the following patch the semantic of uclass_first_device_err/uclass_next_device_err will be changed to be based on uclass_first_device_check/uclass_next_device_check breaking this sole user that uses uclass_next_device_err for iteration. Signed-off-by: Michal Suchanek Reviewed-by: Simon Glass --- drivers/block/blk-uclass.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) Applied to u-boot-dm, thanks!