From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CA0C433F5 for ; Sat, 6 Nov 2021 03:17:06 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B85D60F45 for ; Sat, 6 Nov 2021 03:17:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B85D60F45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 23FD38377A; Sat, 6 Nov 2021 04:16:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="VPF7L1pJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C48D38327C; Sat, 6 Nov 2021 04:16:41 +0100 (CET) Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A30B883763 for ; Sat, 6 Nov 2021 04:16:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x934.google.com with SMTP id e2so20617394uax.7 for ; Fri, 05 Nov 2021 20:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=P17OnKxVheAl76BoL0XIa7F3sgBIwah5QjSWmu79wQA=; b=VPF7L1pJKybe88ZC8Ln1n7ZegvZAoc3P0mCN8W1DbYe9hfzLut/vrXWL2YhzkqWccP B1mHI7HP6pyoz6+iHujR7UpG7QzMGJRT75FTYKhPr3a69Oev6VzKUtvf3FeYUQrxU9hB gG6kMbmfabNKia2zyLEzEavOphDK9ScvlFdcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=P17OnKxVheAl76BoL0XIa7F3sgBIwah5QjSWmu79wQA=; b=LE3M8RiHlUivdks2jrhedBGrmlzfY1vDabtA0yyd0HLibpXh9N5av8hit/3h3kzgK9 HbEHuTBKeFRqUfa5Oa2Gtcs8y220ai0lWtQ+6viOnhnaBZJHNNWC9qL88J9/RCj1FDv7 r6h0Tc+hlgw9XNKwb9SyY/ytEcYsWmNQORx/DyU1Qt8qP63g3rgaDi7wxx1eC8NasuqI yn3fFDjH78hyj/HXtqfueVKpihxOEyyspNpVLivirum7I/qPW0luY17ydg0ZpULc5Y8D HysXV8wwk8GiwYOK20e5LPRhSyqSUCUoLTrsxq0u83bNgX+qUej57MHWmAlr9W0qyXVE CtQw== X-Gm-Message-State: AOAM5309Nlhpdh69Drk+mxGUzUJo1CqNWzrnnQxuyOJYhKtdYkgo6ZnE FMzMOfWW8ngC9Mngx3OJOFmFetxPLB1BIkK5UJg4k3DtSY0= X-Google-Smtp-Source: ABdhPJytWf1GSJFCDsbm/JMhLg0p7DIp1lnxc0pxDCbN+xa9Ky4LNr1XoXRbM8XS3IVWIHoBqbovYZMJ84kbobVn3CE= X-Received: by 2002:a67:db0b:: with SMTP id z11mr613073vsj.59.1636168596119; Fri, 05 Nov 2021 20:16:36 -0700 (PDT) MIME-Version: 1.0 References: <20211105200952.47866-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20211105200952.47866-1-andriy.shevchenko@linux.intel.com> From: Simon Glass Date: Fri, 5 Nov 2021 21:16:25 -0600 Message-ID: Subject: Re: [PATCH v1 1/2] image: Fix typo in boot_get_kbd() To: Andy Shevchenko Cc: Ovidiu Panait , u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko wrote: > > After the commit 4ed37abc49c2 ("image: Remove ifdefs around > image_setup_linux() el at"): > > common/image-board.c: In function =E2=80=98boot_get_kbd=E2=80=99: > common/image-board.c:902:17: error: expected =E2=80=98)=E2=80=99 before = =E2=80=98do_bdinfo=E2=80=99 > 902 | do_bdinfo(NULL, 0, 0, NULL); > | ^~~~~~~~~ > common/image-board.c:901:12: note: to match this =E2=80=98(=E2=80=99 > 901 | if (IS_ENABLED(CONFIG_CMD_BDI) > | ^ > common/image-board.c:906:1: error: expected expression before =E2=80=98}= =E2=80=99 token > 906 | } > | ^ > common/image-board.c:906:1: warning: control reaches end of non-void func= tion [-Wreturn-type] > 906 | } > | ^ > > Fix obvious typo. > > Fixes: 4ed37abc49c2 ("image: Remove ifdefs around image_setup_linux() el = at") > Signed-off-by: Andy Shevchenko > > Revert "image: Partially revert too aggressive ifdeferry removal" > > This reverts commit 84631af9d0454ff8252c1aebb1e9c232b8077692. > > Signed-off-by: Andy Shevchenko > --- > common/image-board.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass