From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Thu, 13 Jul 2017 10:45:10 -0600
Subject: [U-Boot] [PATCH 00/30] env: Move environment code to use
	location drivers
In-Reply-To: <20170712122445.GB14320@bill-the-cat>
References: <20170709205313.116174-1-sjg@chromium.org>
 <20170712122445.GB14320@bill-the-cat>
Message-ID: <CAPnjgZ1bODeGaNrcM5cxRqgqqO0j4w9yFyKANypZ3OrwinxDpg@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tom,

On 12 July 2017 at 06:24, Tom Rini <trini@konsulko.com> wrote:
>
> On Sun, Jul 09, 2017 at 02:52:43PM -0600, Simon Glass wrote:
>
> > The environment code is ripe for improvement in various ways. It has lots
> > of duplication and inconsistencies between how things work with different
> > environment locations. It does not properly use Kconfig. Error checking
> > and handling is patchy.
> >
> > This series makes a start at improving things:
> >
> > - moves the rest of the CONFIG_ENV_IS_IN_... options to Kconfig
>
> After this, did you do some checks to make sure that everyone was
> migrated correctly?  I ask since I had made an attempt a while back to
> convert and I found a lot of cases that didn't happen right and ended up
> hacking up something to have every target print all of the env related
> options to a file (and have buildman save it).  But it might have been..


I need to do another pass with this series. I noticed that it doesn't
bisect properly (i.e. some interim commits mess things up that later
ones fix).

>
>
> > - introduces the concept of a location driver for the environment
> > - drops some of the duplicated code
> > - improves error handling a little (more to be done here)
> > - moves code into a new env/ directory
> >
> > There is still much more to do:
> > - complete Kconfig conversion (e.g. CONFIG_ENV_SIZE)
>
> Because I was converting these parts as well.

I think that is much harder because this option often uses other
options in its expression, but perhaps it is not as bad as I think.

>
> Overall the series looks good.

OK thanks. I'll make time to respin this and send v2 next week.

Regards,
Simon