All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] patman: add test for SPDX license
Date: Sat, 23 Jun 2018 08:06:12 -0600	[thread overview]
Message-ID: <CAPnjgZ1bm9Ba-gB3A9V0H3=EZFjo3qu85=s27vcxahJyufjF3w@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ1SxWcMwwGt8JZfnLcV-y8H9bMzTSQJ3abP-QqkKGriVw@mail.gmail.com>

On 8 June 2018 at 15:59, Simon Glass <sjg@chromium.org> wrote:
> On 7 June 2018 at 00:45, Chris Packham <judge.packham@gmail.com> wrote:
>> Add a test to exercise the check for a valid SPDX license.
>>
>> Signed-off-by: Chris Packham <judge.packham@gmail.com>
>> ---
>> This is dependent on http://patchwork.ozlabs.org/patch/914202/
>>
>> I also seem to get a bunch of doctest failures due to unicode strings, e.g.
>>
>>   File "tools/patman/settings.py", line 78, in settings._ProjectConfigParser
>>   Failed example:
>>       sorted(config.items("settings"))
>>   Expected:
>>       [('am_hero', 'True')]
>>   Got:
>>       [('am_hero', u'True')
>>
>> I haven't attempted to fix these as I suspect they might be python
>> version (2.7.12 for me) and/or locale dependent.
>
> That is a bit odd since I would expect those lists to be the same.
> Normally you can compare uincode and strings without any trouble.
>
>>
>> Changes in v3:
>> - new
>>
>> Changes in v2: None
>>
>>  tools/patman/test.py | 18 ++++++++++++++++--
>>  1 file changed, 16 insertions(+), 2 deletions(-)
>>
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!

  reply	other threads:[~2018-06-23 14:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07  8:45 [U-Boot] [PATCH v3 1/2] patman: add option for limiting the Cc list Chris Packham
2018-06-07  8:45 ` [U-Boot] [PATCH v3 2/2] patman: add test for SPDX license Chris Packham
2018-06-08 21:59   ` Simon Glass
2018-06-23 14:06     ` Simon Glass [this message]
2018-06-08 21:59 ` [U-Boot] [PATCH v3 1/2] patman: add option for limiting the Cc list Simon Glass
2018-06-23 14:06   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ1bm9Ba-gB3A9V0H3=EZFjo3qu85=s27vcxahJyufjF3w@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.