From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Mon, 14 Dec 2020 21:28:47 -0700 Subject: [PATCH v2 00/26] dm: Change the way sequence numbers are implemented In-Reply-To: References: <20201211013151.1927814-1-sjg@chromium.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Michael, On Sat, 12 Dec 2020 at 11:38, Simon Glass wrote: > > Hi Michael, > > On Sat, 12 Dec 2020 at 10:53, Michael Walle wrote: > > > > Hi Simon, > > > > Am 2020-12-12 16:39, schrieb Simon Glass: > > >> Sequence numbers looks good, but PCI still doesnt work on my board. > > > > > > Thanks for trying this out. > > > > > > I suppose you have a different problem from what I found in v1. Can > > > you please send the output of these things before and after the > > > change? > > > > > > dm tree > > > dm uc > > > pci > > > pci 1 > > > (e.g. for other buses) > > > pci 0 long > > > [..] > > > > > > Which board is it? I suppose there is a chance I have one. > > > > Kontron SMARC-sAL28 (kontron_sl28 defconfig) (a LS1028A SoC) > > Thanks for the info. I was worried that the renumbering might cause > problems but saw no issues on my x86 board. > > If you look at the sequence numbers for PCI they have changed. They > also correspond to the bus numbers, and PCI uses the sub bus number to > route access to sub bus, so I suspect one of your buses is not getting > traffic. > > At present the only fix is to add all buses into the DT. I'll take a > look and see what else I can do. I've pushed an experimental tree to u-boot-dm/seq3-working Are you able to take a look and send the same output as last time? I am trying to change how PCI allocation happens, so that it follows the PCI rules. Hopefully the change makes sense to you but I would appreciate any insights you may have. Regards, Simon