From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Sun, 8 Jan 2012 08:35:21 -0800
Subject: [U-Boot] [PATCH 01/14] Add AES crypto library
In-Reply-To: <201201081140.49340.marek.vasut@gmail.com>
References: <1324927987-13100-1-git-send-email-sjg@chromium.org>
	<201201080957.48063.marek.vasut@gmail.com>
	<201201080409.12513.vapier@gentoo.org>
	<201201081140.49340.marek.vasut@gmail.com>
Message-ID: <CAPnjgZ1cgBKkgAUS__0d47WGfOfs7kza0GX=sUqE5Cj_KLZO0w@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

On Sun, Jan 8, 2012 at 2:40 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> On Sunday 08 January 2012 03:57:47 Marek Vasut wrote:
>> > > On Monday 26 December 2011 14:32:54 Simon Glass wrote:
>> > > > --- /dev/null
>> > > > +++ b/lib/aes.c
>> > > >
>> > > > +static u8 sbox[256] = {
>> > > > +static u8 inv_sbox[256] = {
>> > > > +static u8 x2_sbox[256] = {
>> > > > +static u8 x3_sbox[256] = {
>> > > > +static u8 x_time_9[256] = {
>> > > > +static u8 x_time_b[256] = {
>> > > > +static u8 x_time_d[256] = {
>> > > > +static u8 x_time_e[256] = {
>> > >
>> > > const
>> > >
>> > > > +static void mix_sub_columns(u8 *state)
>> > > > +{
>> > > > ...
>> > > > + ? ? ? ? ? ? ? ?x3_sbox[state[2]] ^ ? ? ? sbox[state[7]];
>> > >
>> > > looks bad whitespace after that ^
>> > >
>> > > > +static u8 rcon[11] = {
>> > >
>> > > const
>> >
>> > We already have checkpatch in tools ... run it on the series.

This happened as part of my using patman to submit this series. I just
checked it again and there are no warnings.

>>
>> i don't think checkpatch catches const

Nope.

>> -mike
>
> No, but it catches whitespaces ... M

Not in this case, unfortunately. Sometimes we still need beady eyes :-)

I will fix these two.

Regards,
Simon

> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot