From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48C59C433EF for ; Wed, 12 Jan 2022 20:08:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5E5B383481; Wed, 12 Jan 2022 21:05:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="AGo4LVog"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9D3E88339D; Wed, 12 Jan 2022 21:04:42 +0100 (CET) Received: from mail-oo1-xc31.google.com (mail-oo1-xc31.google.com [IPv6:2607:f8b0:4864:20::c31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D4B868349D for ; Wed, 12 Jan 2022 21:04:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oo1-xc31.google.com with SMTP id q16-20020a4a3010000000b002dde2463e66so860055oof.9 for ; Wed, 12 Jan 2022 12:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f5SmkjEAypUoMGZeDH6tmVASsiCXElEHHQ0Gd7DL71g=; b=AGo4LVogsMG4qBndJ8B5NBFRa/PZgiXJC7atF59sK30u35z0LVHe2mKFdhWijtrcgh QM3K4yRLbNkFtVnkfk3ZadBPWWP7XhEgPem9srAXrFUaDJWJq4crpWBHaeDMRMMJnZPL pffA4l/5vyab93EzyRs2RChe0meP36BrzL7ps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f5SmkjEAypUoMGZeDH6tmVASsiCXElEHHQ0Gd7DL71g=; b=vX+S+Q3JMcRI4ufMNbJw9iDQSp3iGQUxptxqa4Fimx2MsrXclVhNgBIXiqf0cGcR0O MZj6DzeFAejY6iQor5l3Zj4qiHIqk7TWDx6TLiYpfb+X2vBDPfrjHC6fAmokbRpc+Inl ZT/vYt/8k8MzMr+iDO671ohTzxjk53AuAMV2GkJnmj7kAzC0ldhJduLNAopPp2B1ohBz SB+VQNn25IA0aq95C6mgAXbPOg8hLdtYTVaXxVYI0DE1Ikj6fMvX0gZUZoT5UkzcE7cr DqGhlGF4WBqxD7eglM+LGbrhCAbvxXWLHNIckF9qDgfcUO8qQ5Gcv1DAYS//i9jHNHgc /YpQ== X-Gm-Message-State: AOAM531eyQRkSNv9xqLyv2el0tVZbktNY0/Ejm51SbU1XYYqwSjchVKz wn5fhqZof37CNc7oHk/igY8HECsE57oft/qfux7k2ffA5NA= X-Google-Smtp-Source: ABdhPJylC/NzCZx7zmJggHNhCOkEUjO2aKltxnOHK707/pJAlg1bvXwUxkNauQu9c362LeV2qUovqFE7FCs+cPXm/so= X-Received: by 2002:a4a:4c45:: with SMTP id a66mr788369oob.97.1642017876123; Wed, 12 Jan 2022 12:04:36 -0800 (PST) MIME-Version: 1.0 References: <20211231161327.24918-1-francis.laniel@amarulasolutions.com> <20211231161327.24918-17-francis.laniel@amarulasolutions.com> In-Reply-To: <20211231161327.24918-17-francis.laniel@amarulasolutions.com> From: Simon Glass Date: Wed, 12 Jan 2022 13:03:37 -0700 Message-ID: Subject: Re: [RFC PATCH v1 16/21] test: hush: Fix variable expansion tests for hush 2021. To: Francis Laniel Cc: U-Boot Mailing List , Marek Behun , Michael Nazzareno Trimarchi , Wolfgang Denk , Harald Seiler Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Francis, On Fri, 31 Dec 2021 at 09:14, Francis Laniel wrote: > > This commit modifies the expected result for hush 2021. > Indeed, there were bugs in actual U-Boot hush which were fixed in upstream > Busybox. > As hush 2021 is based on upstream Busybox, these bugs no longer exist. > > Signed-off-by: Francis Laniel > --- > test/hush/dollar.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) Reviewed-by: Simon Glass Can you avoid the preprocessor macros? Also, for testing we really want to be able to run both sets of tests in sandbox, so the parser needs to be run-time selectable. Regards, Simon