From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] ARM: tegra: fix USB controller aliases
Date: Sun, 18 Sep 2016 18:58:53 -0600 [thread overview]
Message-ID: <CAPnjgZ1d23jWAy_qm9PMwxi6H8y2Us6vfrmLoJR-zSv--xrFug@mail.gmail.com> (raw)
In-Reply-To: <20160915181939.12167-2-swarren@wwwdotorg.org>
On 15 September 2016 at 12:19, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Some boards have a different set of USB controllers enabled in DT than
> the set referenced by /alias entries. This patch fixes that. For
> example, this avoids the following message while booting on Ventana,
> which is caused by the fact that the USB0 controller had no alias, and
> defaulted to wanting a sequence number of 0, which was later explicitly
> requested by the alias for USB controller 2.
>
> USB2: Device 'usb at c5008000': seq 0 is in use by 'usb at c5000000'
>
> This didn't affect USB operation in any way though.
>
> Related, there's no need for the USB controller aliases to have an order
> that's different from the HW order, so re-order any aliases to match the
> HW ordering. This has the benefit that since USB controller 0 is the only
> one that supports device-mode in HW, and U-Boot only supports enabling
> device move on controller 0, there's now good synergy in the ordering! For
> Tegra20, that's not relevant at present since USB device mode doesn't work
> correctly on that SoC, but it will save some head-scratching later.
>
> This patch doesn't fix the colibri_t20 board, even though it has the same
> issue, since Marcel already sent a patch for that.
>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> arch/arm/dts/tegra20-harmony.dts | 3 ++-
> arch/arm/dts/tegra20-seaboard.dts | 5 +++--
> arch/arm/dts/tegra20-trimslice.dts | 3 +--
> arch/arm/dts/tegra20-ventana.dts | 4 +++-
> 4 files changed, 9 insertions(+), 6 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
next prev parent reply other threads:[~2016-09-19 0:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 18:19 [U-Boot] [PATCH 1/3] ARM: tegra: fix USB ULPI PHY reset signal inversion confusion Stephen Warren
2016-09-15 18:19 ` [U-Boot] [PATCH 2/3] ARM: tegra: fix USB controller aliases Stephen Warren
2016-09-19 0:58 ` Simon Glass [this message]
2016-09-20 13:52 ` Marcel Ziswiler
2016-09-15 18:19 ` [U-Boot] [PATCH 3/3] ARM: tegra: fix ULPI PHY on Ventana and Seaboard Stephen Warren
2016-09-19 0:59 ` Simon Glass
2016-09-19 0:58 ` [U-Boot] [PATCH 1/3] ARM: tegra: fix USB ULPI PHY reset signal inversion confusion Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ1d23jWAy_qm9PMwxi6H8y2Us6vfrmLoJR-zSv--xrFug@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.