All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH v3 3/4] console: remove #ifdef CONFIG_CONSOLE_RECORD
Date: Fri, 18 Dec 2020 20:34:54 -0700	[thread overview]
Message-ID: <CAPnjgZ1dgdU2S3tT5PD7=92gBZG0e+LXwyDn-MJbNmGyKkFGNw@mail.gmail.com> (raw)
In-Reply-To: <20201218124642.v3.3.I3e15d39becc5c180a3be52571bb570e29c6b4cd0@changeid>

On Fri, 18 Dec 2020 at 04:46, Patrick Delaunay
<patrick.delaunay@foss.st.com> wrote:
>
> From: Patrick Delaunay <patrick.delaunay@st.com>
>
> Add helper functions to access to gd->console_out and gd->console_in

I don't see those in this patch

> with membuff API and replace the #ifdef CONFIG_CONSOLE_RECORD test
> by if (IS_ENABLED(CONFIG_CONSOLE_RECORD)) to respect the U-Boot
> coding rule.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - move the tests on gd->flags & GD_FLG_RECORD in helper functions
> - remove test on IS_ENABLED(CONFIG_CONSOLE_RECORD)
>   before to call helper functions
>
>  common/console.c | 95 +++++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 73 insertions(+), 22 deletions(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

  reply	other threads:[~2020-12-19  3:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 11:46 [PATCH v3 0/4] console: remove #ifdef CONFIG when it is possible Patrick Delaunay
2020-12-18 11:46 ` [PATCH v3 1/4] " Patrick Delaunay
2020-12-19  3:34   ` Simon Glass
2021-01-16 16:24   ` Tom Rini
2020-12-18 11:46 ` [PATCH v3 2/4] console: add function console_devices_set Patrick Delaunay
2021-01-16 16:24   ` Tom Rini
2020-12-18 11:46 ` [PATCH v3 3/4] console: remove #ifdef CONFIG_CONSOLE_RECORD Patrick Delaunay
2020-12-19  3:34   ` Simon Glass [this message]
2021-01-04 13:18     ` Patrick DELAUNAY
2021-01-16 16:24   ` Tom Rini
2020-12-18 11:46 ` [PATCH v3 4/4] console: add console_has_tstc helper function for CONSOLE_MUX Patrick Delaunay
2020-12-19  3:34   ` Simon Glass
2021-01-16 16:24   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ1dgdU2S3tT5PD7=92gBZG0e+LXwyDn-MJbNmGyKkFGNw@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.