From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Thu, 25 Aug 2016 06:04:37 -0600
Subject: [U-Boot] [RFC PATCH 2/2] Makefile: Give a build error if ad-hoc
 CONFIG options are added
In-Reply-To: <169169d2-61fc-cec2-7d02-87e7e5c6c99d@wwwdotorg.org>
References: <1472049854-4891-1-git-send-email-sjg@chromium.org>
 <1472049854-4891-3-git-send-email-sjg@chromium.org>
 <169169d2-61fc-cec2-7d02-87e7e5c6c99d@wwwdotorg.org>
Message-ID: <CAPnjgZ1e6dwfC1pLqzvV9HGb7yYk7NH5bg_0uOamRtodKv3qeQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stephen,

On 24 August 2016 at 10:24, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 08/24/2016 08:44 AM, Simon Glass wrote:
>>
>> New CONFIG options should be added via Kconfig. To help prevent new ad-hoc
>> CONFIGs from being added, give a build error when these are detected.
>
>
> Acked-by: Stephen Warren <swarren@nvidia.com>
> Tested-by: Stephen Warren <swarren@nvidia.com>
>
> I worried about the increased build time due to find/grep on all Kconfig
> files, but at least with a hot disk cache it seems to make no noticeable
> difference:-)
>
> FWIW, CONFIG_SPL_GPIO_SUPPORT is missing in the whitelist, which affects the
> Jetson TK1 build (and likely all/most other Tegra boards).
>
> Ah, that's why "CONFIG_" is in the current whitelist; there are Makefiles
> that reference CONFIG_$(SPL)_SOMETHING. Handling that automatically might be
> a little involved for a one-off thing; I guess you'd need to manually fix up
> the whitelist for this?

I'm not sure yet. There are a large number of failures so for the real
patch I'll have to figure out something. I was hoping that a bit more
sed stuff will solve it, but we'll see.

Regards,
Simon