From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7BE3C07E99 for ; Mon, 5 Jul 2021 15:33:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45AB361997 for ; Mon, 5 Jul 2021 15:33:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45AB361997 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 28250800AA; Mon, 5 Jul 2021 17:31:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="faRj4C9C"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5C60C82C4E; Mon, 5 Jul 2021 17:31:08 +0200 (CEST) Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9855182C56 for ; Mon, 5 Jul 2021 17:31:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x230.google.com with SMTP id h9so21140369oih.4 for ; Mon, 05 Jul 2021 08:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c9dUVFPZBokiIW4TCQFI4Hexv/RKxSTng4s4rYXcqS0=; b=faRj4C9Cei0c2SASNCqk6S86L4un19MUrSP0w3FMI/2Yk4lGy5pGl0FZzIa4/47VQB 4+fRpf/UhEJOOIAKCwYiTTwV6bSkOCuNvnHWFV40kAnm03d/TEq6K5iAzuzm1HI/bbG4 VYCLRXAt9p7HQI2Bb+B1MK/l0wGrRFoZMNr6M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c9dUVFPZBokiIW4TCQFI4Hexv/RKxSTng4s4rYXcqS0=; b=YmJ+tWpkTEQ3Fy2WehMdCl2oe9gcfisL5oKXsajMcjdE+op1PRq3RqvvKJ7qT5EvKT RezyeV/8y0QXDKMOLF7zL7zs3qWVFQ+Pg3z26k6UIP0f9qQ/PsMyl49wwuK0tElQsann zIsRI+74T1jrJsJL8ib9EEFai51mnM6jTN/9ZRZF9s0rGNBRyx4Ql6V+UCeu3xP7twZc oBsQsHUd26JN391AMJwiCIwadg0F/jOyrOxmseAyf381bV+g3dAlRm4OQotW2QCs2ygv kckGTmKjfvbs3tcGlcaJAwVYigrRue54t69IxYSpAnzihKYkImxo5j6tPrczcgdt6+8B NEdQ== X-Gm-Message-State: AOAM5331zm+WzJjCgyenahTOIMp1TIoiLd/IIt+GT33A6nX178lkaHxH IyXZR8oBLU1G5y8m3TE8q7i1fbo+p7eljsJ2M2hxbg== X-Google-Smtp-Source: ABdhPJwyq6iaE/AnyjrGhU94lcNrHTYix0sDvkFMEe9ghkQ2ckX5LSkmhANMoS/E3U1YtoxoPja31i0FIytnFQiLzwY= X-Received: by 2002:aca:43c6:: with SMTP id q189mr10070701oia.81.1625499060862; Mon, 05 Jul 2021 08:31:00 -0700 (PDT) MIME-Version: 1.0 References: <20210704193446.84776-1-marek.vasut+renesas@gmail.com> In-Reply-To: <20210704193446.84776-1-marek.vasut+renesas@gmail.com> From: Simon Glass Date: Mon, 5 Jul 2021 09:29:56 -0600 Message-ID: Subject: Re: [PATCH] sysinfo: rcar3: Add Renesas R-Car Gen3 sysinfo driver To: Marek Vasut Cc: U-Boot Mailing List , Marek Vasut , Sean Anderson Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Marek, On Sun, 4 Jul 2021 at 13:35, Marek Vasut wrote: > > The Renesas R-Car Gen3 development kits contain board ID EEPROM. > This driver parses out the board ID and revision out of that > EEPROM and exports it e.g. for the board-info print on boot. > > Signed-off-by: Marek Vasut > Cc: Sean Anderson > Cc: Simon Glass > --- > drivers/sysinfo/Kconfig | 7 ++ > drivers/sysinfo/Makefile | 1 + > drivers/sysinfo/rcar3.c | 197 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 205 insertions(+) > create mode 100644 drivers/sysinfo/rcar3.c > Reviewed-by: Simon Glass > diff --git a/drivers/sysinfo/Kconfig b/drivers/sysinfo/Kconfig > index 381dcd8844..e35f7cb179 100644 > --- a/drivers/sysinfo/Kconfig > +++ b/drivers/sysinfo/Kconfig > @@ -17,6 +17,13 @@ config SYSINFO_GAZERBEAM > help > Support querying device information for the gdsys Gazerbeam board. > > +config SYSINFO_RCAR3 > + bool "Enable sysinfo driver for the Renesas R-Car Gen3" > + depends on RCAR_GEN3 && I2C_EEPROM > + default y if RCAR_GEN3 > + help > + Support querying SoC version information for Renesas R-Car Gen3. > + > config SYSINFO_SANDBOX > bool "Enable sysinfo driver for the Sandbox board" > help > diff --git a/drivers/sysinfo/Makefile b/drivers/sysinfo/Makefile > index d9f708b7ea..680dde77fe 100644 > --- a/drivers/sysinfo/Makefile > +++ b/drivers/sysinfo/Makefile > @@ -5,5 +5,6 @@ > obj-y += sysinfo-uclass.o > obj-$(CONFIG_SYSINFO_GAZERBEAM) += gazerbeam.o > obj-$(CONFIG_SYSINFO_GPIO) += gpio.o > +obj-$(CONFIG_SYSINFO_RCAR3) += rcar3.o > obj-$(CONFIG_SYSINFO_SANDBOX) += sandbox.o > obj-$(CONFIG_SYSINFO_SMBIOS) += smbios.o > diff --git a/drivers/sysinfo/rcar3.c b/drivers/sysinfo/rcar3.c > new file mode 100644 > index 0000000000..c2f4ddfbbe > --- /dev/null > +++ b/drivers/sysinfo/rcar3.c > @@ -0,0 +1,197 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2021 Marek Vasut > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#define BOARD_CODE_MASK 0xF8 > +#define BOARD_REV_MASK 0x07 > +#define BOARD_CODE_SHIFT 0x03 > + > +#define BOARD_SALVATOR_X 0x0 > +#define BOARD_KRIEK 0x1 > +#define BOARD_STARTER_KIT 0x2 > +#define BOARD_SALVATOR_XS 0x4 > +#define BOARD_EBISU 0x8 > +#define BOARD_STARTER_KIT_PRE 0xB > +#define BOARD_EBISU_4D 0xD > +#define BOARD_DRAAK 0xE > +#define BOARD_EAGLE 0xF > + > +/** > + * struct sysinfo_rcar_priv - sysinfo private data > + * @boardname: board model and revision > + * @val: board ID value from eeprom > + */ > +struct sysinfo_rcar_priv { > + char boardmodel[64]; > + u8 val; > +}; > + > +static int sysinfo_rcar_detect(struct udevice *dev) > +{ > + struct sysinfo_rcar_priv *priv = dev_get_priv(dev); > + > + return priv->val == 0xff; > +} > + > +static int sysinfo_rcar_get_str(struct udevice *dev, int id, size_t size, char *val) > +{ > + struct sysinfo_rcar_priv *priv = dev_get_priv(dev); > + > + switch (id) { > + case SYSINFO_ID_BOARD_MODEL: > + strncpy(val, priv->boardmodel, size); > + val[size - 1] = '\0'; strlcpy() [...\ You might consider using return log_msg_ret("xxx", ret) for errors. Regards, Simon