From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E49C433EF for ; Thu, 14 Oct 2021 15:14:52 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 101D1603E5 for ; Thu, 14 Oct 2021 15:14:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 101D1603E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ED268837FF; Thu, 14 Oct 2021 17:12:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="LAp9JE8R"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5AC5C837BD; Thu, 14 Oct 2021 17:11:26 +0200 (CEST) Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BE33B83795 for ; Thu, 14 Oct 2021 17:11:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oo1-xc2f.google.com with SMTP id j11-20020a4a92cb000000b002902ae8cb10so1989015ooh.7 for ; Thu, 14 Oct 2021 08:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TjobZ2qCKNcQ6ZejqkCXW+herMsvtj+Yzta7uIF+D4w=; b=LAp9JE8Rzmc/oTbCYdBvqqahSFaip3F674jQ1kXZTog+tjOfZ8i1KskyUjj31eRjwZ Edhjj6mrSGNstATTSRFxp/a+YpftLE2iX79I8u1D9vvBTtNQmTrzNLr5dJq3yEaxFYMA nbUJY0exLNS+Hf/k3vBwD5tlB3MqaXx/horKE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TjobZ2qCKNcQ6ZejqkCXW+herMsvtj+Yzta7uIF+D4w=; b=FHJmVFXhO8IUasU7bjtzRtDtvL2T6wpaa7yNH6nJEg6zB0pJe2UWy4q4YTztce3C+1 /OKxvj+4arDoksQRS9pR8qfpPVnjBrp8hRHSMbwsc1+z2IzDckHPEIswtxRAJeHEvUvM 4t1L9LjzYrXMYWkJd9sX9qssHVziMF88zVyfdldQ4SEA2b+wbIFxPyTRESJ+OIL14vJ5 emJ6alODK22S8xO86ASgc9Zm42LhraVlLJgPciNaAr7HqXDbImjgOcq/rpATiDdn1t+l TwazFQvnXUVu2cRgNRac9J6Rwr0+NR1sylRDK0vxzRzTGuGIe2UjwraG5RKPy8h3qs8a 3zjQ== X-Gm-Message-State: AOAM530FZjqNmlr8XKtLCwRZ1d3bjwueGklf2YJdbD53jNjPiPawY93p xE/DpRJQk+BtkdP0XDc473d5FBuHEXAsw3fXyH40mpzn X-Google-Smtp-Source: ABdhPJwXdZCgV9tn7JjauP2judgp6H7F8PohecpMMH8z4Dbs3bPPz8ebHLQUnnjGD40oG+KOe8MyIrjsegwO4SS+yrY= X-Received: by 2002:a4a:5549:: with SMTP id e70mr4554462oob.81.1634224278904; Thu, 14 Oct 2021 08:11:18 -0700 (PDT) MIME-Version: 1.0 References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-3-kabel@kernel.org> In-Reply-To: <20211013154557.28479-3-kabel@kernel.org> From: Simon Glass Date: Thu, 14 Oct 2021 09:11:05 -0600 Message-ID: Subject: Re: [PATCH v2 02/13] env: Drop env_get_char_spec() and old, unused .get_char() implementations To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > Commit b2cdef4861be ("env: restore old env_get_char() behaviour") > dropped the .get_char() method from struct env_driver, but left the two > existing implementations (eeprom and nvram) in case someone would use > them by overwriting weak function env_get_char_spec(). > > Since this was never done in the 3.5 years, let's drop these methods and > simplify the code. > > Signed-off-by: Marek Beh=C3=BAn > --- > env/eeprom.c | 18 ------------------ > env/env.c | 7 +------ > env/nvram.c | 14 -------------- > 3 files changed, 1 insertion(+), 38 deletions(-) > Reviewed-by: Simon Glass