From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04E06C4338F for ; Wed, 4 Aug 2021 14:36:52 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0385360FC3 for ; Wed, 4 Aug 2021 14:36:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0385360FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9FADC82E0C; Wed, 4 Aug 2021 16:36:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="FveCrEL1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0DD3982E1E; Wed, 4 Aug 2021 16:36:47 +0200 (CEST) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 360BF82E04 for ; Wed, 4 Aug 2021 16:36:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wm1-x334.google.com with SMTP id b128so1345527wmb.4 for ; Wed, 04 Aug 2021 07:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Odzo7sY7RQuWbS7ILc1H6592QZT8l7OzIjPXYvZjDY0=; b=FveCrEL1IyydZTmvh3dPf+QPmDrZdvbGOhnkXTldyr9NbFQRsemw+E6/NJ5YYwFkEW xGuIzs2IM2QpqAcpzNp/iL8NA+7jHb5vz+oSg6VRyzzDTGZp9ru9aeMHvXpqyvS3D760 jD8aD+une+LKQ2tKZVFH+lJXyT4/7kLQDbgKI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Odzo7sY7RQuWbS7ILc1H6592QZT8l7OzIjPXYvZjDY0=; b=U1c46sA+u2lbb6LTMH9skhcCJHVCjYlZsoU/zh/HA3golOaLERQDws5VfbrzpnNq8g uhmA1XhXTxhhYg+2wYinGK0NMR4l6V5MOgVtRpHSHBMw81MTq2nFaYtz3lPGthLgoGFF QIOJMeHeT2VSMexPvP4NdH2FwHCaaNQKcsELKmz4udJ+beGPpeZRHOYFPtUhsMm3CROV FuA6B4RhfiBcmUYMZbHcsh5NiYKf7ee4Rx+HG8ENRt2Ab6n3fG4aRu7dkB/7wJ3vAxjc Hk+SapjRCy8B1+MeTqnnVMrVAX71uaA9WRzS4o00qcUPZUGJvrs0LPKt6qPyORRbtRA6 ok5g== X-Gm-Message-State: AOAM532kBfmBx/jm6trPHrjPd16rKzoap08eRGvCODg7i9yxK9gYcAvA W7eGmbJU12lPmlIUeLyjJ5xZFu7o3zq1rXK5x7EHxw== X-Google-Smtp-Source: ABdhPJxqNBCFxzBfFCqaSHECpunEobYyl9/G3yJiuhrlthSjYTtYxDEDYQQX5qEUVdKntln+C7i1Yw7IhLfUVT9b+z0= X-Received: by 2002:a1c:413:: with SMTP id 19mr27681742wme.74.1628087798406; Wed, 04 Aug 2021 07:36:38 -0700 (PDT) MIME-Version: 1.0 References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-12-pali@kernel.org> <20210802194223.5myvz6l27rjkfrld@pali> <20210802213100.GG9379@bill-the-cat> <128122.1628056761@gemini.denx.de> <20210804124413.GZ9379@bill-the-cat> In-Reply-To: <20210804124413.GZ9379@bill-the-cat> From: Simon Glass Date: Wed, 4 Aug 2021 08:36:27 -0600 Message-ID: Subject: Re: [PATCH 11/11] Remove including timestamp.h in version.h To: Tom Rini Cc: Wolfgang Denk , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Priyanka Jain , Christophe Leroy , Bin Meng , =?UTF-8?B?TWFyZWsgQmVow7pu?= , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Wed, 4 Aug 2021 at 06:44, Tom Rini wrote: > > On Wed, Aug 04, 2021 at 07:59:21AM +0200, Wolfgang Denk wrote: > > > Dear Tom, > > > > In message <20210802213100.GG9379@bill-the-cat> you wrote: > > > > > > I think that if nothing changes the banner not changing is the right > > > behavior. > > > > Hm... is it? How about "external" changes like building with a > > different tool chain? Then at least the "version" command should > > produce a corresponding output, which means some parts _have_ to be > > recompiled, resulting in a new banner, too ? > > There's some misunderstanding about what this series does, and does not > do. First, with the series applied and you don't force > SOURCE_DATE_EPOCH, and you run make, and you re-run make, cmd/version.c > is rebuilt (but only that and not a bunch of other things anymore) and > the banner timestamp changes. Second, if you do set SOURCE_DATE_EPOCH > to a fixed value (so you're trying to reproduce a build with a specific > timestamp) AND re-run make, nothing changes, as it should. Third, if > you change gcc, everything gets rebuilt including cmd/version.c and a > new banner. Yes that's my understanding and it seems fine. Regards, Simon