From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CED54C05027 for ; Thu, 26 Jan 2023 18:04:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6251B8560A; Thu, 26 Jan 2023 19:04:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="WCGiQrw8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4B44B856CC; Thu, 26 Jan 2023 19:04:26 +0100 (CET) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0416E85463 for ; Thu, 26 Jan 2023 19:04:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ej1-x632.google.com with SMTP id hw16so7219028ejc.10 for ; Thu, 26 Jan 2023 10:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3AKZOi3ZhoeYvLhlxhpnD1IQrkAD7zzGox29HBbWLQk=; b=WCGiQrw8RNDMZC2AmI/NZwvN0AUT1ORWJXaDZ/KLfKWFMK0SrODOCllVwSYpe/u3Vg rpDjIv5UqWDGxb2EF4wKLUSOGGe4yPgfcpj18AulT4YaE+R8dff7xlaGM2GGGXLjMYCz Weh6tmMs2sH0btTN0snWuL0yOOMi/RkQksEvA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3AKZOi3ZhoeYvLhlxhpnD1IQrkAD7zzGox29HBbWLQk=; b=OiLMgHKJNhkXOu3oxVGwdTvDa/IoBqeTb4SzSlobPQnIH5WYVsh2o3FWGmOLqZcKsv rrgbAaWgA/SoDmX3bKHVyWVhUU9AxhiM/cgCApyE1iAZdYPjrZDfrq1jQiOX/IjJY4x0 FkDh2SUlTXfNebmGzdjZ2PwUF1KaZTNCvknx9+ydMKvXV3lKShHBuNXtEQO/Y1tSG5Lw eQgQv5Nn+6nCK4dJ1FeUBEa/SQwxk2vVfK3kxsPqJX9Y82f64BXON3bw4VaqJkz8tpse yo2+qzs6urQhOorob1qMbNJOj+IR4W217rcZmUiyy7C8iZWq9Z7IZShD1QwPJBslIcC5 S2VQ== X-Gm-Message-State: AO0yUKXAQoE8FxMPjgkFyTz/yaw2dgdJwY/wfiV/6/77Q4QtL/Aycfpo a4MKCyilOlcHq/HwC1jjLiqFde17EBATjZsmbgFVyw== X-Google-Smtp-Source: AK7set8wXWl02j1KuwOCUwy7Ktn1Ylj7RNMwj2g875U2geL7a4VHVIAm+NV+QDyQXHfKG7lEYEbriJzUYdXMh3E+vKs= X-Received: by 2002:a17:906:b147:b0:878:3054:335f with SMTP id bt7-20020a170906b14700b008783054335fmr1750655ejb.214.1674756261338; Thu, 26 Jan 2023 10:04:21 -0800 (PST) MIME-Version: 1.0 References: <20230125222741.303259-1-jagan@edgeble.ai> <2efd56b6-4dc9-cd77-3792-e60142faa6ae@kwiboo.se> <64443c40-03b1-bfe2-23fe-ad61236d7dde@kwiboo.se> In-Reply-To: From: Simon Glass Date: Thu, 26 Jan 2023 11:04:06 -0700 Message-ID: Subject: Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support To: Jagan Teki Cc: Jonas Karlman , Kever Yang , Philipp Tomsich , fatorangecat@189.cn, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Jagan, On Thu, 26 Jan 2023 at 10:42, Jagan Teki wrote: > > On Thu, 26 Jan 2023 at 22:28, Jonas Karlman wrote: > > > > Hi Jagan, > > On 2023-01-26 17:51, Jagan Teki wrote: > > > Hi Jonas, > > > > > > On Thu, 26 Jan 2023 at 04:17, Jonas Karlman wrote: > > >> > > >> Hi Jagan, > > >> > > >> On 2023-01-25 23:27, Jagan Teki wrote: > > >>> This series support Rockchip RK3588. All the device tree files are > > >>> synced from linux-next with the proper SHA1 mentioned in the commit > > >>> messages. > > >>> > > >>> Unfortunately, the BL31 from rkbin is not compatible with U-Boot so > > >>> it is failing to load ATF entry from SPL and hang. > > >>> > > >>> Verified below BL31 versions, > > >>> bl31-v1.15 > > >>> bl31-v1.21 > > >>> bl31-v1.22 > > >>> bl31-v1.23 > > >>> bl31-v1.24 > > >>> bl31-v1.25 > > >>> bl31-v1.26 > > >>> > > >>> Rever-engineered with respect to rockchip u-boot by using the same > > >>> FIT_GENERATOR being used in Mainline, rockchip u-boot is booting bu= t > > >>> mainline showing the same issue. > > >>> > > >>> Log: > > >>> > > >>> LPDDR4X, 2112MHz01-00642-g6bdfd31756-dirty (Jan 26 2023 =EF=BF=BD= =EF=BF=BD=EF=BF=BD3:44:34 +0530) > > >>> channel[0] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D17 CS1 Row=3D17 CS=3D2= Die BW=3D8 Size=3D4096MB > > >>> channel[1] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D17 CS1 Row=3D17 CS=3D2= Die BW=3D8 Size=3D4096MB > > >>> channel[2] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D17 CS1 Row=3D17 CS=3D2= Die BW=3D8 Size=3D4096MB > > >>> channel[3] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D17 CS1 Row=3D17 CS=3D2= Die BW=3D8 Size=3D4096MB > > >>> change to F1: 528MHz > > >>> change to F2: 1068MHz > > >>> change to F3: 1560MHz > > >>> change to F0: 2112MHz > > >>> out > > >>> > > >>> U-Boot SPL 2023.01-00642-g6bdfd31756-dirty (Jan 26 2023 - 03:44:34 = +0530) > > >>> Trying to boot from MMC1 > > >>> bl31_entry: atf_entry start > > >>> << hang >> > > >>> > > >>> Any information on BL31 for RK3588 please share. > > >> > > >> I had a similar strange booing issue with RK3568 and mainline U-Boot= , > > >> turned out to be related to all parts of ATF not being properly load= ed > > >> into PMU SRAM. > > >> > > >> Using my series at [1] I managed to get ATF to be fully loaded into > > >> PMU SRAM. Using CONFIG_SPL_FIT_SIGNATURE=3Dy helped me finding out t= hat > > >> the segment being loaded ended up corrupted. > > >> > > >> The use of 512 bytes alignment of the FIT helped mitigate that issue= . > > >> Vendor U-Boot use a bounce buffer for all parts that is written into > > >> SRAM (anything loaded outside the gd->ram_base to gd->ram_top range)= . > > >> > > >> You can also find newer bl31 at [2], up to version v1.32. > > >> > > >> [1] https://patchwork.ozlabs.org/project/uboot/list/?series=3D337891= >>> [2] https://gitlab.com/rk3588_linux/rk/rkbin/-/tree/linux-5.10-gen-rkr3= .5/bin/rk35>> > > > Thanks for the details. I did apply this set on the master. No change > > > in the behavior, used BL31 and ddr from [2] as well as in > > > rkbin/master. > > > > I did some tests on my Radxa ROCK 3 Model B with CONFIG_SPL_FIT_SIGNATU= RE=3Dy > > and it looked like it failed to read data into memory, see below. > > > > It also looks like the sdhci compatible is not supported by the driver. > > Something that may need to be added to driver to properly read data? > > > > > > DDR V1.09 a930779e06 typ 22/11/21-17:50:56 > > LPDDR4X, 2112MHz > > channel[0] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D16 CS1 Row=3D16 CS=3D2 Die= BW=3D16 Size=3D2048MB > > channel[1] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D16 CS1 Row=3D16 CS=3D2 Die= BW=3D16 Size=3D2048MB > > channel[2] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D16 CS1 Row=3D16 CS=3D2 Die= BW=3D16 Size=3D2048MB > > channel[3] BW=3D16 Col=3D10 Bk=3D8 CS0 Row=3D16 CS1 Row=3D16 CS=3D2 Die= BW=3D16 Size=3D2048MB > > Manufacturer ID:0x6 > > CH0 RX Vref:31.7%, TX Vref:21.8%,20.8% > > CH1 RX Vref:31.7%, TX Vref:21.8%,21.8% > > CH2 RX Vref:32.7%, TX Vref:22.8%,21.8% > > CH3 RX Vref:32.7%, TX Vref:21.8%,20.8% > > change to F1: 528MHz > > change to F2: 1068MHz > > change to F3: 1560MHz > > change to F0: 2112MHz > > out > > > > U-Boot SPL 2023.01 (Jan 26 2023 - 00:24:53 +0000) > > Trying to boot from MMC1 > > ## Checking hash(es) for config config_1 ... OK > > ## Checking hash(es) for Image atf_1 ... sha256 error! > > Bad hash value for 'hash' hash node in 'atf_1' image node > > mmc_load_image_raw_sector: mmc block read error > > Trying to boot from MMC1 > > ## Checking hash(es) for config config_1 ... OK > > ## Checking hash(es) for Image atf_1 ... sha256 error! > > Bad hash value for 'hash' hash node in 'atf_1' image node > > Look like this is something wrong with your patch series or master > changes on binman, not with the driver. I have observed the same if I > enable CONFIG_SPL_FIT_SIGNATURE. There are some more changes in dm/master that I'm about to pull in. One of them from Jonas Karlman adds hash nodes so may be involved. Regards, Simon