All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: "Christian Kohlschütter" <christian@kohlschutter.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH] common: board_f: Fix crash in print_cpuinfo
Date: Wed, 28 Sep 2022 20:36:03 -0600	[thread overview]
Message-ID: <CAPnjgZ1jhb7NwMvYw6E43gt4zj+dsW5Yw-r+SHKEOKeJOA_v9g@mail.gmail.com> (raw)
In-Reply-To: <20220929002008.9177-1-christian@kohlschutter.com>

Hi Christian,

On Wed, 28 Sept 2022 at 18:20, Christian Kohlschütter
<christian@kohlschutter.com> wrote:
>
> With CONFIG_DISPLAY_CPUINFO=y and CONFIG_CPU=y, the initcall sequence
> may fail (and therefore hang the boot process) with an -ENODEV (err=-19)
> error code.
>
> This is caused by either cpu_get_current_dev/cpu_get_desc failing to
> return CPU information.
>
> If no CPU information can be obtained, fall-back to the non-Driver Model
> implementation of print_cpuinfo.
>
> Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
> ---
>  common/board_f.c | 14 +++++++++-----
>  include/init.h   |  3 +--
>  2 files changed, 10 insertions(+), 7 deletions(-)

No, we don't want to do this. If you have CPU enabled then the device
must return the info. The non-DM code will go away one day. It is not
intended as a fallback.

Regards,
Simon

  reply	other threads:[~2022-09-29  2:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29  0:20 [PATCH] common: board_f: Fix crash in print_cpuinfo Christian Kohlschütter
2022-09-29  2:36 ` Simon Glass [this message]
2022-09-29 14:24   ` Christian Kohlschütter
2022-09-29 23:55     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1jhb7NwMvYw6E43gt4zj+dsW5Yw-r+SHKEOKeJOA_v9g@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=christian@kohlschutter.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.