All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Joel Peshkin <joel.peshkin@broadcom.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH] BRCMNAND: Fix reporting of uncorrectable errors on subpages during page read
Date: Tue, 28 Dec 2021 01:33:29 -0700	[thread overview]
Message-ID: <CAPnjgZ1kg94pJpUiBuSaEE8jp9t2Gg01CVxizStAP_cS_7Sv5A@mail.gmail.com> (raw)
In-Reply-To: <20211221041547.52964-1-joel.peshkin@broadcom.com>

On Mon, 20 Dec 2021 at 21:15, Joel Peshkin <joel.peshkin@broadcom.com> wrote:
>
> Previously, a subpage with an uncorrectable error followed by a subpage
> with a correctable error would return an erroneous correctable status.
>
> Signed-off-by: Joel Peshkin <joel.peshkin@broadcom.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Note that we normally like to have the commit subject 60 chars at most.


>
> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> index f8434ca..74c9348 100644
> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> @@ -1632,7 +1632,7 @@ static int brcmnand_read_by_pio(struct mtd_info *mtd, struct nand_chip *chip,
>                                         mtd->oobsize / trans,
>                                         host->hwcfg.sector_size_1k);
>
> -               if (!ret) {
> +               if (ret != -EBADMSG) {
>                         *err_addr = brcmnand_read_reg(ctrl,
>                                         BRCMNAND_UNCORR_ADDR) |
>                                 ((u64)(brcmnand_read_reg(ctrl,
> --
> 1.8.3.1
>

  reply	other threads:[~2021-12-28  8:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21  4:15 [PATCH] BRCMNAND: Fix reporting of uncorrectable errors on subpages during page read Joel Peshkin
2021-12-28  8:33 ` Simon Glass [this message]
2022-01-15 12:38 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1kg94pJpUiBuSaEE8jp9t2Gg01CVxizStAP_cS_7Sv5A@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=joel.peshkin@broadcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.