From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Tue, 24 Nov 2015 13:32:07 -0700 Subject: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter In-Reply-To: References: <1447402284-26598-1-git-send-email-bmeng.cn@gmail.com> <1447402284-26598-6-git-send-email-bmeng.cn@gmail.com> <564FBD9C.8080203@wytron.com.tw> <56546DBD.8050806@wytron.com.tw> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 24 November 2015 at 11:23, Simon Glass wrote: > Hi Thomas, > > On 24 November 2015 at 07:01, Thomas Chou wrote: >> Hi Simon, >> >> On 2015?11?24? 18:09, Simon Glass wrote: >>> >>> >>> Unfortunately this causes build errors for a few avr32 boards - e.g. >>> grasshopper. >>> >>> I think the problem is the gd declaration in the timer.h header file. >>> I don't think that is a good idea. Can we move it to the C file? >> >> >> If you meant, "warning: input is not relaxable", it is fixed after commit >> f300dccde433 ("i2c, avr32: fix compiler warning "input is not relaxable""). >> The u-boot-dm/testing branch does not have such warning. > > Please try u-boot-dm/testing. This seems to be a different problem: > > avr32: + grasshopper > +lib/time.c:20: warning: register used for two global register variables > > We should not declare the global_data pointer in a header file. > > Bin, are you able to take a look? Perhaps the function that needs it > should move to the C file? I've had a crack at this and will send an updated patch. Regards, Simon