From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 13 Apr 2017 15:16:37 -0600 Subject: [U-Boot] [PATCH v3 1/2] ARM: at91: gpio: fix at91_set_gpio_value() define In-Reply-To: References: <20170323045522.13807-1-wenyou.yang@atmel.com> <20170323045522.13807-2-wenyou.yang@atmel.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 31 March 2017 at 22:21, Simon Glass wrote: > On 22 March 2017 at 22:55, Wenyou Yang wrote: >> When the CONFIG_ATMEL_LEGACY is undefined, according to the following >> defines, at91_set_gpio_value() references to at91_set_pio_value(x, y) >> with two parameters. >> #define at91_set_gpio_value(x, y) at91_set_pio_value(x, y) >> #define at91_get_gpio_value(x) at91_get_pio_value(x) >> >> But there isn't the implementation of at91_set_pio_value(x, y) with >> two parameters in U-Boot. This is an error. >> >> Same as at91_get_gpio_value(x) define. >> >> Signed-off-by: Wenyou Yang >> --- >> >> Changes in v3: None >> Changes in v2: >> - Improve the commit log. >> >> arch/arm/mach-at91/include/mach/gpio.h | 12 +++++------- >> 1 file changed, 5 insertions(+), 7 deletions(-) > > Reviewed-by: Simon Glass Applied to u-boot-dm, thanks!