From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sun, 8 Jan 2012 09:27:54 -0800 Subject: [U-Boot] [RFC PATCH v2 04/15] bootstage: Convert progress numbers 1-9 into enums In-Reply-To: <201201080327.52666.vapier@gentoo.org> References: <1323551287-5351-1-git-send-email-sjg@chromium.org> <1323551287-5351-5-git-send-email-sjg@chromium.org> <201201080327.52666.vapier@gentoo.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Mike, On Sun, Jan 8, 2012 at 12:27 AM, Mike Frysinger wrote: > On Saturday 10 December 2011 16:07:56 Simon Glass wrote: >> --- a/include/bootstage.h >> +++ b/include/bootstage.h >> >> ?enum bootstage_id { >> + ? ? BOOTSTAGE_ID_START, >> + ? ? BOOTSTAGE_ID_CHECK_MAGIC, ? ? ? /* Checking image magic */ >> + ? ? BOOTSTAGE_ID_CHECK_HEADER, ? ? ?/* Checking image header */ >> + ? ? BOOTSTAGE_ID_CHECK_CHECKSUM, ? ?/* Checking image checksum */ >> + ? ? BOOTSTAGE_ID_CHECK_ARCH, ? ? ? ?/* Checking architecture */ > > i know it's unlikely to ever change, but this would be good to be explicit: > ? ? ? ?BOOTSTAGE_ID_START = 0, > -mike done Regards, Simon