All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot 2/3] cmd: add rockusb command
Date: Wed, 22 Mar 2017 07:05:44 -0600	[thread overview]
Message-ID: <CAPnjgZ1qpbH74QO5Cgj2TVAm8vvuw8U9_zO7yRvVKukGZYSooQ@mail.gmail.com> (raw)
In-Reply-To: <CAJrj+DNC3dJUDRcufqapF90ZYcrNhJzY3Mezpgq4mwRFV0iMqQ@mail.gmail.com>

Hi Eddie,

On 20 March 2017 at 02:14, Eddie Cai <eddie.cai.linux@gmail.com> wrote:
> Hi Simon
>
> 2017-03-20 10:29 GMT+08:00 Simon Glass <sjg@chromium.org>:
>>
>> Hi Eddie,
>>
>> On 15 March 2017 at 01:56, Eddie Cai <eddie.cai.linux@gmail.com> wrote:
>> >
>> > this patch add rockusb command. the usage is
>> >         rockusb <USB_controller> [<devtype>] <devnum>
>> > e.g. rockusb 0 mmc 0
>> >
>> > Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
>> > ---
>> >  cmd/Kconfig       | 12 +++++++++
>> >  cmd/Makefile      |  1 +
>> >  cmd/rockusb.c     | 79
>> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> >  include/rockusb.h | 13 +++++++++
>> >  4 files changed, 105 insertions(+)
>> >  create mode 100644 cmd/rockusb.c
>> >  create mode 100644 include/rockusb.h
>>

[..]

>>
>> > +       "rockusb <USB_controller> [<devtype>] <devnum>  e.g. rockusb 0
>> > mmc 0\n"
>> > +       "    devtype defaults to mmc"
>> > +);
>> > diff --git a/include/rockusb.h b/include/rockusb.h
>> > new file mode 100644
>> > index 0000000..cdea63d
>> > --- /dev/null
>> > +++ b/include/rockusb.h
>>
>> Can this go in include/asm instead?
>
> do you mean include/asm-generic ? may i know why ?

No I was thinking of arch/arm/include/asm/arch-rockchip. Because this
is a rockchip-specific file, isn't it?

Regards,
Simon

  reply	other threads:[~2017-03-22 13:05 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15  7:56 [U-Boot] [U-Boot 0/3] introduce Rockchip rockusb Eddie Cai
2017-03-15  7:56 ` [U-Boot] [U-Boot 1/3] drivers: usb: gadget: add the rockusb gadget Eddie Cai
2017-03-16  7:05   ` Kever Yang
2017-03-20  7:24     ` Eddie Cai
2017-03-20  8:37       ` Lukasz Majewski
2017-04-20  0:56         ` Eddie Cai
2017-04-20 10:04   ` Lukasz Majewski
2017-03-15  7:56 ` [U-Boot] [U-Boot 2/3] cmd: add rockusb command Eddie Cai
2017-03-20  2:29   ` Simon Glass
2017-03-20  8:14     ` Eddie Cai
2017-03-22 13:05       ` Simon Glass [this message]
2017-04-20 10:11   ` Lukasz Majewski
2017-03-15  7:56 ` [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device Eddie Cai
2017-03-20  2:30   ` Simon Glass
2017-03-20  8:16     ` Eddie Cai
2017-05-02 10:37     ` Eddie Cai
2017-05-03 10:09       ` Simon Glass
2017-05-04  7:17         ` Eddie Cai
2017-05-04  9:19           ` Lukasz Majewski
2017-05-04 16:49             ` Simon Glass
2017-05-05  1:15               ` Eddie Cai
2017-05-14  9:32                 ` Simon Glass
2017-05-14 21:49                   ` Lukasz Majewski
2017-04-20 10:12   ` Lukasz Majewski
2017-03-15  9:06 ` [U-Boot] [U-Boot 0/3] introduce Rockchip rockusb Lukasz Majewski
2017-03-15  9:31   ` Eddie Cai
2017-03-15  9:46     ` Lukasz Majewski
2017-03-16 21:26 ` Marek Vasut
2017-03-20  1:53   ` Eddie Cai
2017-03-20 12:24     ` Marek Vasut
2017-03-20 16:01       ` Simon Glass
2017-03-20 16:33         ` Marek Vasut
2017-03-21  5:17           ` Kever Yang
2017-03-21 14:27             ` Tom Rini
2017-03-27  8:27 ` Lukasz Majewski
2017-03-28  9:13   ` Eddie Cai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1qpbH74QO5Cgj2TVAm8vvuw8U9_zO7yRvVKukGZYSooQ@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.