From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Sun, 16 Apr 2017 13:34:00 -0600
Subject: [U-Boot] [RFC 1/1] omap3: incorrect logical check in
	do_emif4_init
In-Reply-To: <20170415141112.27145-1-xypron.glpk@gmx.de>
References: <20170415141112.27145-1-xypron.glpk@gmx.de>
Message-ID: <CAPnjgZ1r6Hr+MfmnNYbWden8BNVuKBPnBYn9d2Jrp1PsXHw7FQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 15 April 2017 at 08:11, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> ((readl(&emif4_base->sdram_iodft_tlgc) & (1<<10)) == 0x01)
> is always false.
> This does not match the comment
> /*Wait till that bit clears*/
>
> The problem was indicated by cppcheck.
>
> I do not have the hardware to test if the code change below
> leads to a correct system behavior.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  arch/arm/mach-omap2/omap3/emif4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>