All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/6] dm: x86: Update timer_get_boot_us to work before DM is ready
Date: Tue, 5 Sep 2017 19:39:33 -0600	[thread overview]
Message-ID: <CAPnjgZ1rYoQWoWFsqaUm5VWgpUBN7NWxoiHvTT_7YrQ983XB7A@mail.gmail.com> (raw)
In-Reply-To: <CAEUhbmUw7iD8-7M11QoyB2s_e6tWn_cSo=836HQKjJ2xdjAZAw@mail.gmail.com>

Hi Bin,

On 27 August 2017 at 23:18, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Simon,
>
> On Sun, Aug 27, 2017 at 11:23 PM, Simon Glass <sjg@chromium.org> wrote:
>> Use the new separate init function so that we can make use of the timer
>> before driver model is started up.
>>
>> At some point we should consider adding the microsecond timer to the timer
>> uclass interface since it would reduce the amount of plumbing here
>> slightly.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> Changes in v2:
>> - Rebase on top of early timer code and simplify slightly
>>
>>  drivers/timer/tsc_timer.c | 19 ++++++++++++++-----
>>  1 file changed, 14 insertions(+), 5 deletions(-)
>>
>
> I don't think this patch is needed. The early timer support was
> already provided in the patch [2/6] in this series.

The current version of timer_get_boot_us() does not init the timer if
it is not set up, so will return incorrect values at the start.

So I think this patch is needed.

Regards,
Simon

  reply	other threads:[~2017-09-06  1:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-27 15:23 [U-Boot] [PATCH v2 0/6] x86: bootstage: Fix bootstage operation on link Simon Glass
2017-08-27 15:23 ` [U-Boot] [PATCH v2 1/6] board_f: Drop the timer after relocation Simon Glass
2017-08-28  5:18   ` Bin Meng
2017-08-27 15:23 ` [U-Boot] [PATCH v2 2/6] dm: x86: Allow TSC timer to be used before DM is ready Simon Glass
2017-08-28  5:18   ` Bin Meng
2017-08-27 15:23 ` [U-Boot] [PATCH v2 3/6] dm: x86: Update timer_get_boot_us to work " Simon Glass
2017-08-28  5:18   ` Bin Meng
2017-09-06  1:39     ` Simon Glass [this message]
2017-09-12 13:47       ` Bin Meng
2017-09-14  2:15         ` Simon Glass
2017-08-27 15:23 ` [U-Boot] [PATCH v2 4/6] bootstage: Drop unused options Simon Glass
2017-08-28  5:18   ` Bin Meng
2017-08-27 15:23 ` [U-Boot] [PATCH v2 5/6] bootstage: Provide a separate record count setting for SPL Simon Glass
2017-08-28  5:18   ` Bin Meng
2017-08-27 15:23 ` [U-Boot] [PATCH v2 6/6] x86: Enable early timer for chromebook_link Simon Glass
2017-08-28  5:18   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1rYoQWoWFsqaUm5VWgpUBN7NWxoiHvTT_7YrQ983XB7A@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.