From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4462C07E99 for ; Mon, 5 Jul 2021 21:02:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1F4961987 for ; Mon, 5 Jul 2021 21:02:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1F4961987 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7EF7782B66; Mon, 5 Jul 2021 23:02:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="PkLSiEav"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 567C582BD2; Mon, 5 Jul 2021 23:02:39 +0200 (CEST) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A08EA82B66 for ; Mon, 5 Jul 2021 23:02:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wm1-x329.google.com with SMTP id a5-20020a7bc1c50000b02901e3bbe0939bso791293wmj.0 for ; Mon, 05 Jul 2021 14:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qZvSGtCfzpP9xw6CrYYnFFfz2qUf8QX18kpEmBiLETw=; b=PkLSiEavq1y0qtGDA+Pb/TG7RBWac+UDQ0TG35e0/FqkX54/RYncFaEiV7s5lJirHC bAwpgbmOjv1T0qCFxVLjsFO2WLbsaRCZ3Fvqd6bPSUAc9duQT6o5AcDmdR/xvjS+Lkmo ywVD5NnxZDUaBXywAMzBrDZBGT6KA+Z4s9RHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qZvSGtCfzpP9xw6CrYYnFFfz2qUf8QX18kpEmBiLETw=; b=d/v1beeito6V71DIaiR+sjx0gnbtodBn4rM2qZso264Rgmyat5k9XtYsrB2gxl53s5 83+YKSMJD4+Sn+INBMPzCSIQw2HT4oVdxsHhLYWA4KV/dXHUlhOqOmVfy6QYhN6fdupD FVpNuYgi+jF9zfljuU6QPp3BDnoJVxz8yBqrv4oV4kCpp1FUUwjFbTSB8Nrxu5/0Qyoa 5hNa80+bUW1KPLNgwP059WVu+QAgPyD3YEPfGOXqE3ul/GjfYxH859d2EjpFUJnDa/gl eD4Y6N4jDONq9LZP7T0Z72WSpdZiL6n2fXiS6X18XJn2/nrLXl0XyjbFPu26b5x6z+92 MQQg== X-Gm-Message-State: AOAM5324o0dW7xoAImkR9r7mu1QzQjx31hRE8mIdKQHBHpQLqsynyxkF dX7HF6iMtl9CCcPY3iPK0UI1Jp011Ks/EjWkUq+Eqg== X-Google-Smtp-Source: ABdhPJxukjnJkKb8I2RfMZQ4KjpjqMlw8Dya5avQzpuInZaLLUvpYfqeb4AquS+9VTjz7Pzd0Lk8ZewFKKH0kbiQntU= X-Received: by 2002:a1c:4e0c:: with SMTP id g12mr937306wmh.120.1625518955700; Mon, 05 Jul 2021 14:02:35 -0700 (PDT) MIME-Version: 1.0 References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-6-seanga2@gmail.com> <163753.1625507898@gemini.denx.de> <20210705185141.GA9516@bill-the-cat> In-Reply-To: <20210705185141.GA9516@bill-the-cat> From: Simon Glass Date: Mon, 5 Jul 2021 15:02:24 -0600 Message-ID: Subject: Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL To: Tom Rini Cc: Wolfgang Denk , Sean Anderson , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Mon, 5 Jul 2021 at 12:51, Tom Rini wrote: > > On Mon, Jul 05, 2021 at 07:58:18PM +0200, Wolfgang Denk wrote: > > Dear Sean, > > > > In message you wrote: > > > > > > > Is your intent to create a fork of this in U-Boot? > > > > > > Yes. I believe some of the major additions I have made (especially "[RFC > > > PATCH 21/28] cli: lil: Add a distinct parsing step") would not be > > > accepted by upstream. > > > > Ouch... > > > > > > Could we not update things upstream, at least as an option, to avoid > > > > carrying these patches? > > > > > > For some of the smaller patches, that may be possible. However, I am not > > > a fan of the major amount of ifdefs that Hush has. For something as core > > > as a shell, I think we should be free to make changes as we see fit > > > without worrying about how it will affect a hypothetical backport. > > > > I'm afraind I cannot understand your thinking. > > > > You complain that the existing port of hus has a number of severe > > limitations or bugs which have long been fixed upstream, but cannot > > be easily fixed in U-Boot because we essentially created an > > unmaintained fork - and as a cure, you recommend to do the same > > thing again, but this time intentionally and deliberately? > > > > > > If you had not apparently already invested a lot of effort into this > > thing I would assume you must be joking... > > > > To me such an approach is unacceptable. > > I think I want to try and address this. While with "hush" we have > something that's in heavy active development outside of U-Boot, with LIL > we have something that's mature and "done". Tracking an active outside > development is HARD and requires constant resync. Look at the last few > LIL releases. That could be easily re-worked in to our fork if needed. > I see that as a positive, not a negative. Yes I wondered about that, since hush has been in busybox, an active project, all these years. I think this is a good point and perhaps means that forking it should not be too much of a concern. Still, if we can send some things upstream, we should. Regards, Simon