From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFD38C433EF for ; Thu, 2 Dec 2021 15:59:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB685811B3; Thu, 2 Dec 2021 16:59:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="W6xWL7oc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9A033811AC; Thu, 2 Dec 2021 16:59:30 +0100 (CET) Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3FAD7811B3 for ; Thu, 2 Dec 2021 16:59:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa2f.google.com with SMTP id e27so18790413vkd.4 for ; Thu, 02 Dec 2021 07:59:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OJgKfjlaoAhltBUx3+BvHpuzioGc+iXfuCkdP5UwHac=; b=W6xWL7ocbdAqy1oq9nxDT5MzoReHfJzYNveFFw/VvwrnJe8bJYqtMkuoNZEsOaoBur af111YZf1DuwgbhRnX5q4GA0AJvfmepWlNVP56kJCB67OE1cohH8D5I2dOQ/xL+ptYSr knJSSpz3a1qas4pDHO6jOuFZ3ocXhv/3x1cmI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OJgKfjlaoAhltBUx3+BvHpuzioGc+iXfuCkdP5UwHac=; b=frf56Sy7+vvWjrt+r/m8I5EDxsod8RaBwtBxzbKSpNCryu5WgPoAbbj5sdkM+uv0EV AdTvRSOsY8CueV43y1KJiorkMH2iZlF1kiKKCKEjgllyAtrMKuw+N4TcnQeuKJkgzoCd V3yS4WJ2SZzWfCVeajUYYuTM1bWbBhVhZMsmvOcV3/KO1lIsOTRdrU66Y+ymehabPjDw uYQK/YulGQmcGtPqIFZMEfuCu0SiFOL/xFKqkbphqH7KpgPfoKFot3QFqWhr/edgouWO I9f95iZKOqQB1eSIur5iYv2nkq39kg/Ua7RFfAdHv0pJhO0EW+GdIiOzczhCb8s9SU9P QUng== X-Gm-Message-State: AOAM532opyr2hzPcUoo6vClfM73/ZKfVyy8SsmnDVNPrZ6OKMa+g1qBF EYy/d0jqOAGxMr3/kIQ/EUIuxBOTO3xPyhtsG+7TuA== X-Google-Smtp-Source: ABdhPJyLmZo3K4HRHmQwFwLQUNLBfLijuPGaKloqG5Fwr2mgrXuzVhmClY0NDQkcIQWAv0sg4mKYiFvGrf2JKSOdkJM= X-Received: by 2002:a05:6122:8d6:: with SMTP id 22mr16878603vkg.21.1638460764631; Thu, 02 Dec 2021 07:59:24 -0800 (PST) MIME-Version: 1.0 References: <20211201184332.2166897-1-seanga2@gmail.com> <20211201184332.2166897-6-seanga2@gmail.com> <1528d504-21d5-97da-27bf-a6101044f776@gmail.com> In-Reply-To: <1528d504-21d5-97da-27bf-a6101044f776@gmail.com> From: Simon Glass Date: Thu, 2 Dec 2021 08:59:13 -0700 Message-ID: Subject: Re: [PATCH 5/5] clk: Add clk_get_by_name_optional To: Sean Anderson Cc: u-boot@lists.denx.de, Dario Binacchi , Lukasz Majewski , Michal Simek , Neil Armstrong , u-boot-amlogic@groups.io Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Sean, On Thu, 2 Dec 2021 at 07:25, Sean Anderson wrote: > > Hi Simon, > > On 12/2/21 8:43 AM, Simon Glass wrote: > > Hi Sean, > > > > On Wed, 1 Dec 2021 at 11:43, Sean Anderson wrote: > >> > >> This adds a helper function for clk_get_by_name in cases where the clock is > >> optional. Hopefully this helps point driver writers in the right direction. > >> Also convert some existing users. > >> > >> Signed-off-by: Sean Anderson > >> --- > >> > >> drivers/clk/clk_zynq.c | 5 +++-- > >> drivers/rng/meson-rng.c | 4 ++-- > >> include/clk.h | 24 ++++++++++++++++++++++++ > >> 3 files changed, 29 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/clk/clk_zynq.c b/drivers/clk/clk_zynq.c > >> index 18915c3e04..e80500e382 100644 > >> --- a/drivers/clk/clk_zynq.c > >> +++ b/drivers/clk/clk_zynq.c > >> @@ -472,8 +472,9 @@ static int zynq_clk_probe(struct udevice *dev) > >> > >> for (i = 0; i < 2; i++) { > >> sprintf(name, "gem%d_emio_clk", i); > >> - ret = clk_get_by_name(dev, name, &priv->gem_emio_clk[i]); > >> - if (ret < 0 && ret != -ENODATA) { > >> + ret = clk_get_by_name_optional(dev, name, > >> + &priv->gem_emio_clk[i]); > >> + if (ret) { > >> dev_err(dev, "failed to get %s clock\n", name); > >> return ret; > >> } > >> diff --git a/drivers/rng/meson-rng.c b/drivers/rng/meson-rng.c > >> index 5a4f45ad5a..e0a1e8c7e0 100644 > >> --- a/drivers/rng/meson-rng.c > >> +++ b/drivers/rng/meson-rng.c > >> @@ -91,8 +91,8 @@ static int meson_rng_of_to_plat(struct udevice *dev) > >> return -ENODEV; > >> > >> /* Get optional "core" clock */ > >> - err = clk_get_by_name(dev, "core", &pdata->clk); > >> - if (err && err != -ENODATA) > >> + err = clk_get_by_name_optional(dev, "core", &pdata->clk); > >> + if (err) > >> return err; > >> > >> return 0; > >> diff --git a/include/clk.h b/include/clk.h > >> index 103ef16bf9..36721188d0 100644 > >> --- a/include/clk.h > >> +++ b/include/clk.h > >> @@ -292,6 +292,30 @@ static inline int clk_release_all(struct clk *clk, int count) > >> } > >> #endif > >> > >> +/** > >> + * clk_get_by_name_optional() - Get/request a optional clock by name. > > > > Can I suggest we rename this to ..._opt as it is shorter? > > This follows the general trend of suffixing _optional. For example (and > several of these are borrowed from Linux): > > clk_get_optional > reset_control_bulk_get_optional_exclusive > gpiod_get_optional > platform_get_irq_byname_optional > > and particularly, the Linux clock subsystem uses _optional and not _opt > as a suffix. While some of these names can get fairly long-winded, I > think we should go for consistency here. Yes I agree. I do wish people would consider brevity as these names are pretty hopeless for readability. Regards, Simon