From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C525C433FE for ; Mon, 17 Oct 2022 21:31:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B089884F63; Mon, 17 Oct 2022 23:29:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="mZrUMjX3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 58F4684F65; Mon, 17 Oct 2022 23:29:29 +0200 (CEST) Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 36B1B84F5D for ; Mon, 17 Oct 2022 23:29:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x935.google.com with SMTP id a8so4844672uaj.11 for ; Mon, 17 Oct 2022 14:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:references:in-reply-to:from:sender :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UKsfhn1TQVnatHEBfrOdQLf98c6muKP64t5USX+H2Pw=; b=mZrUMjX32aEUgT21xLPtTNICXZAuaDMw1eWPP3eMxFM/iI7xT9bbMY3w+8oXth3MN0 +izs+FlWV8Fw+i80oQ7elJiqTwnxBYfNDIyARYysGLtrnbIH/Y8rV+Gp5tNCsIYGEsBI dt896E0/OO7OBRHtTornWpeUftOLjou5nd6oc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:references:in-reply-to:from:sender :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UKsfhn1TQVnatHEBfrOdQLf98c6muKP64t5USX+H2Pw=; b=SiUJKpjD9OhggvBATlGbm7TB2pnLmb2SH6vpqtNra4Z40HM6w0ooAylGu2HbOEEcRA 80EJsymt9U3VreVBjnZrdsDEuElcV4sYvkCzw42KgqrlUk2nIZQFlBQbTku6Iod9QcHe h8v+3sj3X4GO1mDqBWsWnG2Aw9jcu1qCELQqeKvSxvDygwPDoT+Hwk9equ2H/sMKKVQZ GG5iD9ROUxjZ9WF7rmDWJXOidSoNbw3jbeVmbOhKdUmouexHVIcqkN/bVjESR4GH5d1/ 4ML91+CfpkexsCU5j5KA/iU2IvlqOWQI+29oCNqkK5fkjIhcxJ6yGCBoKdcPsY9Lk/Lj Hd7Q== X-Gm-Message-State: ACrzQf1tlRtkmOHLdKdkxK7ZHR9erdIcw4ShGtzjJO2fFnMSQrz1HYHz EXRE0ohFk16x7FrYouTtyZvtZkgjJJKYnmRLyc/o0A== X-Google-Smtp-Source: AMsMyM4YPfn0Oyh1l4pjDx/cmjvonEqy9ldBTAzvhXrvNxtjvVX37+bque9WVJExSB7f/od6sJwX6xwXZRffnyZQpMY= X-Received: by 2002:ab0:4715:0:b0:3ea:d249:de4c with SMTP id h21-20020ab04715000000b003ead249de4cmr5878699uac.80.1666042162520; Mon, 17 Oct 2022 14:29:22 -0700 (PDT) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Mon, 17 Oct 2022 14:29:20 -0700 MIME-Version: 1.0 From: Simon Glass In-Reply-To: <2776c1f050b8233341263231e0c88c5c1658f19a.1665604425.git.msuchanek@suse.de> References: <2776c1f050b8233341263231e0c88c5c1658f19a.1665604425.git.msuchanek@suse.de> Date: Mon, 17 Oct 2022 14:29:20 -0700 X-Google-Sender-Auth: nrx0-ox3oHNv55LYwG-mH4f-PlQ Message-ID: Subject: Re: [PATCH v6 07/20] video: ipuv3: Fix error handling when getting the display To: Michal Suchanek Cc: Anatolij Gustschin , Simon Glass , Heinrich Schuchardt , Heiko Schocher , u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean The code checks that uclass_first_device returned a device but the returned value that is assigned is never used. Use uclass_first_device_err instead, and move the error return outside of the if block. Fixes: f4ec1ae08e ("mxc_ipuv3_fb.c: call display_enable") Signed-off-by: Michal Suchanek Reviewed-by: Simon Glass --- drivers/video/imx/mxc_ipuv3_fb.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) Applied to u-boot-dm, thanks!