From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C27C433F5 for ; Tue, 5 Oct 2021 14:42:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6082561130 for ; Tue, 5 Oct 2021 14:42:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6082561130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8F7EF80607; Tue, 5 Oct 2021 16:42:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="fasbfVuM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9912C80607; Tue, 5 Oct 2021 16:42:20 +0200 (CEST) Received: from mail-vk1-xa2d.google.com (mail-vk1-xa2d.google.com [IPv6:2607:f8b0:4864:20::a2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E0AE08032F for ; Tue, 5 Oct 2021 16:42:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa2d.google.com with SMTP id u66so3627995vku.4 for ; Tue, 05 Oct 2021 07:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Km0JRHG7pelFZhtEOTPdkKlqYDwoN6HWo4mmjXrv2OI=; b=fasbfVuMbD9OgRD1iBgaSs+sjMMw1UyKxpqz1JkOegBNWmQhJWt1h4zqcTfrqKuOov uNs4Ius2cer3g0AfDqW8HodxBgMlouwLYFcwtAsTrtXsDMgB1QIKCJGu13lwBdL5/Yex YxF6B8UomkLdxjTBG7+PyRCVz7EX6CVNvQ454= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Km0JRHG7pelFZhtEOTPdkKlqYDwoN6HWo4mmjXrv2OI=; b=6+kLU4W2WKpaB4gYM6XVef5dBNVcCdD8XthLgsLKlgC4GUmTnWP+ynlROjOeillEcc JJ3Nc9R1Pq5+WnCdtc4VseU47g0nmN7qu5QPol251nDzaDP0nxQPQ+FlKG6TicMzm/9a Vb17UNgxSXrCfh/VcDNAj+6g18mIkhTyC2Oe2QxfMSCVX0CbnPodF6mVQR3eqPvxqVHw vKYlV0K8Yw4a0L2NoW8q6tOgP7iYU1ksC/cZ7V1jpUYOTJbVxcgkUCNlkN5x1pfd/f+J 490AJUVHMYZcMUHVjQC9c5mi89YwEBQ7B2hY//5Sa7Pja14omC2zJXCiE46rLvpaL77v SThA== X-Gm-Message-State: AOAM533Y1w8XO7fziqItCBD2NMB0Ga9UK/iHtVIL6ujPSZsPQA9NVMFt YrtrViteKrPX3D11oSEWISUHu9Ek3YDlWX/7eeGLkQ== X-Google-Smtp-Source: ABdhPJx1cbRDcqD4Tv9K0tGT2jgrb47asdNjrXfwYrZVpNQxhG9mN9OTvL5OlsUPzssRdWjOgmth33i9KSzPVJoYSZE= X-Received: by 2002:a05:6122:a16:: with SMTP id 22mr6576770vkn.24.1633444935244; Tue, 05 Oct 2021 07:42:15 -0700 (PDT) MIME-Version: 1.0 References: <20211002003848.1803446-1-sjg@chromium.org> <20211001183842.v5.3.If789ba3e2667c46c03eda3386ca84a863baeda55@changeid> <2672911.1633349282@gemini.denx.de> In-Reply-To: <2672911.1633349282@gemini.denx.de> From: Simon Glass Date: Tue, 5 Oct 2021 08:42:03 -0600 Message-ID: Subject: Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file To: Wolfgang Denk Cc: U-Boot Mailing List , Tom Rini , Joe Hershberger Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Wolfgang, On Mon, 4 Oct 2021 at 06:08, Wolfgang Denk wrote: > > Dear Simon, > > In message <20211001183842.v5.3.If789ba3e2667c46c03eda3386ca84a863baeda55@changeid> you wrote: > > > > Add a feature that brings in a .env file associated with the board > > config, if present. To use it, create a file in a board//env > > directory called .env (or common.env if you want the same > > environment for all boards). > > This should be no exclusive "or" here. If a common.env exists, it > should be used for all boards, and if additionally one ore more > .env files exist, these should ALSO be applied to the > respective boards. Is it not enough to use #include in the main file? We have a similar feature with the u-boot.dtsi files and in that case we only choose the most specific. Regards, Simon