From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB78C4338F for ; Sun, 1 Aug 2021 22:02:19 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57F8960F39 for ; Sun, 1 Aug 2021 22:02:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 57F8960F39 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0EE0B832D0; Mon, 2 Aug 2021 00:02:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="K7auwaqf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D0D5E832DA; Mon, 2 Aug 2021 00:02:13 +0200 (CEST) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F1A80831D6 for ; Mon, 2 Aug 2021 00:02:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wm1-x32d.google.com with SMTP id l11-20020a7bcf0b0000b0290253545c2997so9844348wmg.4 for ; Sun, 01 Aug 2021 15:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9/PAPjYrksaQu21EvaMPsA5PXwsRqZJSJun5oGCZ2Ng=; b=K7auwaqfXy8IV+Mwktre4rET1RR3mw2/6rJLtiKfSFijGEoKY/sX94tJWWhJc2DWRg 12tHlX4iFOIcz4juaEbXONC+HW9cVvff4aR1ynNq8MGVdTLsBLrtPFXN8ojQ7yQvYf/2 z5oGYZwEfA0QIuLn4X9OOqXamDFV7Zvh1JNnU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9/PAPjYrksaQu21EvaMPsA5PXwsRqZJSJun5oGCZ2Ng=; b=BYUtazYQHdUuacAd9LorqsUMLJBhXbbvIIkhvL+78C2SQdNq3BHeQRZdPPYzDgH1Ag AqBHUD/YckwG3xvycidza6cUwI6jilXXAN5jlI5XvAsrDlMkp8KS9tHYbr0/BS6kBBtb jgJ6hEnbKUgIV8C/uQfhyRl2uAbB6J3dF5au8K7fEEwsNYCDNhsJFhatNft++BIrgOzX b2iIcgTJpCRiEVpAvLY/YzTf8WpxwMrQiw4D212UBeKsCIgQePFGIagGLU1xXch1THxU xR6xySarSuitr1eoI2zg+lAP1+TZpC0hA8L23jeji1Qs61F+GU6osscYNIT2dQBa5zHQ VPoQ== X-Gm-Message-State: AOAM532qaTB1rBbMnqyuLvOwWfBnoxlxny5sr7DZpWuEapG0XpFAv4UU CFX6LVSo5ez/u7bXpMvnxmHMZ7yv4jqvxSsgBThBCQ== X-Google-Smtp-Source: ABdhPJz9zGDATXufF4SjQ9FKMFQJZl5GaBrc9zTXarUmJJs+oMDyC0o/Xd7i30qTXcbvGF2C9w17VkRlYqOwu/WYVmw= X-Received: by 2002:a1c:2b04:: with SMTP id r4mr13768861wmr.168.1627855329044; Sun, 01 Aug 2021 15:02:09 -0700 (PDT) MIME-Version: 1.0 References: <20210627235111.485507-1-sjg@chromium.org> In-Reply-To: From: Simon Glass Date: Sun, 1 Aug 2021 16:01:57 -0600 Message-ID: Subject: Re: [PATCH v3 00/16] misc: Some more misc patches To: Bin Meng Cc: U-Boot Mailing List , Jagan Teki , Jagannadha Sutradharudu Teki , Stefan Reinauer , Vadim Bendebury Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Bin, On Thu, 15 Jul 2021 at 05:51, Bin Meng wrote: > > Hi Simon, > > On Wed, Jul 14, 2021 at 11:47 PM Simon Glass wrote: > > > > Hi Bin, > > > > On Sun, 27 Jun 2021 at 17:51, Simon Glass wrote: > > > > > > Various issues were discovered in getting Chromium OS verified boot > > > running on top of coreboot, booting into U-Boot. > > > > > > Improvements include: > > > - enable serial console if even coreboot doesn't > > > - enable cache always > > > - show the BIOS date since Chromium OS's coreboot doesn't have a version > > > - update docs > > > - allow SPI driver to work without a PCH > > > - fix mtrr command when multi-processing (CONFIG_MP) is disabled > > > - add documentation about the memory map > > > > > > Changes in v3: > > > - Fix comment to menion u-boot,dm-tpl > > > - Fix 'u-boot,dm-pre-tpl' (it should be u-boot,dm-tpl) > > > > > > Changes in v2: > > > - Add a comment about the cases > > > - Reorder declaration and use bios_date for the variable name > > > - Add missing newline in the error path > > > - Use (ret) instead of (ret != 0) to fit with U-Boot style > > > - Convert table to reST format > > > - Add 'cros' tag since this not a generic x86 change > > > - Drop unnecessary patch 'Enable the cbsysinfo command' > > > > > > Simon Glass (16): > > > pci: Use const for pci_find_device_id() etc. > > > x86: pci: Allow binding of some devices before relocation > > > x86: Allow coreboot serial driver to guess the UART > > > spi: ich: Don't require the PCH > > > tpm: cr50: Drop unnecessary coral headers > > > x86: Don't set up MTRRs if previously done > > > x86: Update the MP constants to avoid conflicts > > > x86: Do cache set-up by default when booting from coreboot > > > x86: coreboot: Show the BIOS date > > > x86: coral: Allow booting from coreboot > > > x86: Add function comments to cb_sysinfo.h > > > x86: coreboot: Use vendor in the Kconfig > > > x86: coreboot: Document the memory map > > > x86: cros: Check ROM exists before building vboot > > > dtoc: Check that a parent is not missing > > > doc: Update documentation for cros-2021.04 release > > > > > > arch/x86/cpu/coreboot/Kconfig | 2 +- > > > arch/x86/cpu/i386/cpu.c | 2 +- > > > arch/x86/dts/chromebook_coral.dts | 2 +- > > > arch/x86/dts/chromebook_samus.dts | 2 +- > > > arch/x86/include/asm/cb_sysinfo.h | 16 ++++++ > > > arch/x86/include/asm/mp.h | 12 +++-- > > > arch/x86/lib/init_helpers.c | 18 +++++-- > > > board/coreboot/coreboot/Kconfig | 12 +++-- > > > board/coreboot/coreboot/coreboot.c | 3 ++ > > > board/google/chromebook_coral/coral.c | 28 ++++++++++ > > > doc/board/coreboot/coreboot.rst | 21 ++++++++ > > > doc/chromium/run_vboot.rst | 15 +++--- > > > doc/device-tree-bindings/pci/x86-pci.txt | 7 ++- > > > drivers/pci/pci-uclass.c | 39 ++++++++++++-- > > > drivers/serial/serial_coreboot.c | 68 +++++++++++++++++++++--- > > > drivers/spi/ich.c | 4 +- > > > drivers/tpm/cr50_i2c.c | 2 - > > > include/dt-bindings/pci/pci.h | 12 +++++ > > > include/pci.h | 5 +- > > > include/pci_ids.h | 1 + > > > tools/dtoc/dtb_platdata.py | 9 ++++ > > > tools/dtoc/test/dtoc_test_noparent.dts | 32 +++++++++++ > > > tools/dtoc/test_dtoc.py | 10 ++++ > > > 23 files changed, 278 insertions(+), 44 deletions(-) > > > create mode 100644 include/dt-bindings/pci/pci.h > > > create mode 100644 tools/dtoc/test/dtoc_test_noparent.dts > > > > > > -- > > > 2.32.0.93.g670b81a890-goog > > > > > > > Do you have any update on this series, please? > > > > Sorry, I just applied this series. > > There are many commits that have a blank line between your SoB tag and > the RB tag which I believe is caused by the patman patchwork > functionality. > > I have manually removed the blank lines when applying. Would you > please fix the patman? I think it might have been due to using an old patman to do that series. But I'm not sure, so I'll send a possible fix. Regards, Simon