All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere
Date: Thu, 16 May 2013 11:49:51 -0700	[thread overview]
Message-ID: <CAPnjgZ1v_wa8fTh7nUU6_vNiVLuVesT+06eC=rsfTCDOeWTL2A@mail.gmail.com> (raw)
In-Reply-To: <20130516162606.GM32163@bill-the-cat>

Hi Tom,

On Thu, May 16, 2013 at 9:26 AM, Tom Rini <trini@ti.com> wrote:
> On Wed, May 15, 2013 at 07:13:18AM -0700, Simon Glass wrote:
>
> [snip]
>> I've brought over the patches that I can that don't depend on autoconf:
>>
>> 6c0e6c9 (HEAD, ws/us-config5, us-config5) main: Add debug_bootkeys to
>> avoid #ifdefs
>> 9777b9f main: Add debug_parser() to avoid #ifdefs
>> 2fc85b6 main: Correct header order
>> 24e80be main: Fix typos and checkpatch warnings in command line reading
>> 9e9e3b9 main: Use get/setenv_ulong()
>> 1290cb7 main: Move boot_delay code into its own function
>> cd8f13e main: Separate out the two abortboot() functions
>> ca2451c net: Add prototype for update_tftp
>> 4a2a802 at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263
>>
>> I will run these through the builder and send an interim series
>> without autoconf. We still have a lot of inline #ifdefs, and static
>> functions and local variables must also be #ifdefed out if not used.
>> Still, there is some improvement.
>
> I've read them over and they look good.  Since you didn't re-send
> anything I assume they passed your builder test and I'll apply them next
> week (and give them my own builder test like everything else gets).
> Thanks!

Yes I did a full build and saw no additional failures from my patch.
But then I did a few whitespace changes and only built a few boards
after that. I think it's OK though.

Regards,
Simon

  reply	other threads:[~2013-05-16 18:49 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26 16:10 [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere Simon Glass
2013-02-26 16:10 ` [U-Boot] [PATCH v3 01/16] Implement autoconf header file Simon Glass
2013-02-26 16:10 ` [U-Boot] [PATCH v3 02/16] at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263 Simon Glass
2013-02-26 16:10 ` [U-Boot] [PATCH v3 03/16] net: Add prototype for update_tftp, and use autoconf Simon Glass
2013-03-20 19:40   ` Tom Rini
2013-03-20 19:57     ` Simon Glass
2013-03-20 20:30       ` Tom Rini
2013-03-21  1:47         ` Simon Glass
2013-02-26 16:10 ` [U-Boot] [PATCH v3 04/16] main: Separate out the two abortboot() functions Simon Glass
2013-02-26 16:10 ` [U-Boot] [PATCH v3 05/16] main: Move boot_delay code into its own function Simon Glass
2013-02-26 16:10 ` [U-Boot] [PATCH v3 06/16] main: Use autoconf for boot retry feature Simon Glass
2013-02-26 16:11 ` [U-Boot] [PATCH v3 07/16] main: Remove CONFIG #ifdefs from the abortboot() code Simon Glass
2013-02-26 16:11 ` [U-Boot] [PATCH v3 08/16] main: Use get/setenv_ulong() Simon Glass
2013-02-26 16:11 ` [U-Boot] [PATCH v3 09/16] main: Use autoconf for boot_delay code Simon Glass
2013-02-27  9:14   ` Joe Hershberger
2013-02-26 16:11 ` [U-Boot] [PATCH v3 10/16] main: Use autoconf for parser selection Simon Glass
2013-02-26 16:11 ` [U-Boot] [PATCH v3 11/16] main: Fix typos and checkpatch warnings in command line reading Simon Glass
2013-02-27  9:25   ` Joe Hershberger
2013-02-26 16:11 ` [U-Boot] [PATCH v3 12/16] main: Use autoconf " Simon Glass
2013-02-27  9:17   ` Joe Hershberger
2013-02-26 16:11 ` [U-Boot] [PATCH v3 13/16] main: Use autoconf in main_loop() Simon Glass
2013-02-27  9:23   ` Joe Hershberger
2013-02-26 16:11 ` [U-Boot] [PATCH v3 14/16] main: Correct header order Simon Glass
2013-02-26 16:11 ` [U-Boot] [PATCH v3 15/16] main: Add debug_parser() to avoid #ifdefs Simon Glass
2013-02-26 16:11 ` [U-Boot] [PATCH v3 16/16] main: Add debug_bootkeys " Simon Glass
2013-03-21 14:38 ` [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere Tom Rini
2013-05-13 22:12   ` Simon Glass
2013-05-14 21:21     ` Tom Rini
2013-05-14 21:27       ` Simon Glass
2013-05-14 22:15         ` Tom Rini
2013-05-14 22:22           ` Vadim Bendebury
2013-05-14 22:28             ` Tom Rini
2013-05-15 14:13               ` Simon Glass
2013-05-16 16:26                 ` Tom Rini
2013-05-16 18:49                   ` Simon Glass [this message]
2013-05-30 13:57                     ` Simon Glass
2013-05-30 15:17                       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ1v_wa8fTh7nUU6_vNiVLuVesT+06eC=rsfTCDOeWTL2A@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.