From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2277DC43217 for ; Mon, 17 Oct 2022 21:32:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7267384F7C; Mon, 17 Oct 2022 23:30:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="JcDHL35g"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 642F084F66; Mon, 17 Oct 2022 23:29:33 +0200 (CEST) Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com [IPv6:2607:f8b0:4864:20::941]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 02FA584F63 for ; Mon, 17 Oct 2022 23:29:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x941.google.com with SMTP id z6so4866394uaq.2 for ; Mon, 17 Oct 2022 14:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:references:in-reply-to:from:sender :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7NKVmu/iUXvomEAxsryo527yUnPOM3LZ7IiAfoM9RNg=; b=JcDHL35gBmK/QreFWKaaB7GAQwBfXdqvToDP/SULq4k7JuPdOTbZf6Mbo3K4ml8/Gx zv5IqW+5f5P6rv7/U/CeTiLld/r8CC+aPnLDX9OoAxAQEH83K6VycO66DPV2idbLfrH2 bAvkxzFMVRy/TDRu6RlZ/C9b66fxgoMbEliaA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:references:in-reply-to:from:sender :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7NKVmu/iUXvomEAxsryo527yUnPOM3LZ7IiAfoM9RNg=; b=6Si/YgQov+Ui1s0m+6ZCPLao5ntt/h4Ko+pjDRCuYWX2c5/OwZpjDC2x1miW7vq5wR ek2l53o9M1VK0HqQ0ms9cKsg+/wWVx1ACjejPoTQfAXYqAwumzrpD4RP058tj/U71ikF 8XZB7RObg9qE4XN8t0JWMfnbnsP9cEPhAS+X8L+QgkUV/X32vDmtUpDAul98HwEnQt/0 IrueEkChCYh2Z0mMheDb4K83SNSYxt6cNpq6YNr14B0mQqmfWnbxGD6DO7cUxXWoSvX/ X4htMvw3KJuKQMRi0QMBmxsKlUpz6LQz7LjjOB68OsiTozyBsA1dMiRP5b0M3i6ocB8J ialQ== X-Gm-Message-State: ACrzQf0QrasCV1fkRvK9vm6KRnm5oJ6iqZyOXQSX5eNvbpmi5TRsAx+s LWMEzSp2MsAGWuBbk9Y6TPrl3pbsgxDvYPROZEagCg== X-Google-Smtp-Source: AMsMyM7zOey+4+uNh5j3LxKRY0U1/BM59Uw6QH7AEmLIReiFOHI5o7Yq9yFfwENQzvQwloeEwY2y6pGBXfWI+8Pyt98= X-Received: by 2002:a9f:358c:0:b0:3e3:4963:3770 with SMTP id t12-20020a9f358c000000b003e349633770mr5380237uad.77.1666042163455; Mon, 17 Oct 2022 14:29:23 -0700 (PDT) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Mon, 17 Oct 2022 14:29:21 -0700 MIME-Version: 1.0 From: Simon Glass In-Reply-To: References: Date: Mon, 17 Oct 2022 14:29:21 -0700 X-Google-Sender-Auth: MdcY1vMdVBapAn8Myqk2bDMrtA0 Message-ID: Subject: Re: [PATCH v6 06/20] stdio: Fix class iteration in stdio_add_devices() To: Michal Suchanek Cc: Simon Glass , Jason Liu , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Heinrich Schuchardt , Loic Poulain , u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean There is a complaint in the code that iterates keyboards that we don't have the _check variant of class iterator but we in fact do, use it. In the code that iterates video devices there is an attempt to print errors but the simple iterator does not return a device when there is an error. Use the _check variant of the iterator as well. Also format error messages consistently. Signed-off-by: Michal Suchanek Reviewed-by: Simon Glass --- v6: - drop errno_str - fix dev vs vdev in video error print --- common/stdio.c | 32 +++++++++++++------------------- 1 file changed, 13 insertions(+), 19 deletions(-) Applied to u-boot-dm, thanks!