From mboxrd@z Thu Jan  1 00:00:00 1970
From: sjg at google.com <sjg@google.com>
Date: Fri, 12 Apr 2019 14:49:55 -0700
Subject: [U-Boot] [PATCH v3 10/13] fdtdec: test: Add carveout tests
In-Reply-To: <20190322084538.GC28640@ulmo>
References: <20190322084538.GC28640@ulmo>
 <20190321181010.27005-1-thierry.reding@gmail.com>
 <20190321181010.27005-11-thierry.reding@gmail.com>
 <CAPnjgZ2Z15wkx7ky_9J94J10T4yHqsrEOXGwq1UpYnn2MGrTsg@mail.gmail.com>
Message-ID: <CAPnjgZ203ePXyi+moiO+ecJ4LS+eL1wuaoNpojxcZB-qTTukDA@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Mar 22, 2019 at 03:53:07PM +0800, Simon Glass wrote:
> Hi Thierry,
>
> On Fri, 22 Mar 2019 at 02:10, Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Implement carveout tests for 32-bit and 64-bit builds.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > Changes in v2:
> > - new patch
> >
> >  lib/fdtdec_test.c | 152 ++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 152 insertions(+)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Just an idea - as an alternative you could use the built-in device
> tree as your base rather than creating a new one. But perhaps that
> would only be safe on sandbox?

Yeah, running that test on a live system would mess up the reserved
memory regions. If U-Boot does something based on the reserved-memory
node, or passes it on to the kernel, that's going to cause issues.

The test also uses rather arbitrary values for the carveout, which may
not point at system memory at all.

Thierry

Applied to u-boot-dm, thanks!