From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Tue, 19 Aug 2014 06:58:34 -0600
Subject: [U-Boot] [PATCH 08/23] Add pr_fmt() macro
In-Reply-To: <20140819122703.GE19515@ulmo>
References: <1408346196-30419-1-git-send-email-thierry.reding@gmail.com>
	<1408346196-30419-9-git-send-email-thierry.reding@gmail.com>
	<CAPnjgZ103iQjvRgRvcwm2QaPzWj=owdp1ZxLhe8XtV6R9vtLZw@mail.gmail.com>
	<20140819122703.GE19515@ulmo>
Message-ID: <CAPnjgZ22JoX92PcmswdyyTFSR2NR_ck8FrtxA6V2N2Z6Ep=fQw@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Thierry,

On 19 August 2014 06:27, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Mon, Aug 18, 2014 at 12:24:06PM -0600, Simon Glass wrote:
>> On 18 August 2014 01:16, Thierry Reding <thierry.reding@gmail.com> wrote:
>> > From: Thierry Reding <treding@nvidia.com>
>> >
>> > This macro can be overridden in source files (before including common.h)
>> > and can be used to specify a prefix for debug and error messages. An
>> > example of how to use this is shown below:
>> >
>> >         #define pr_fmt(fmt) "foo: " fmt
>> >
>> >         #include <common.h>
>> >
>> >         ...
>> >         debug("bar");
>> >
>> > The resulting message will read:
>> >
>> >         foo: bar
>> >
>> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>>
>> Acked-by: Simon Glass <sjg@chromium.org>
>>
>> Seems OK. But I wonder if a string might be simpler?
>>
>> #define DEBUG_PREFIX "foo: "
>>
>> +#ifndef DEBUG_PREFIX
>> +#define DEBUG_PREFIX ""
>> +#endif
>
> The advantage of using the macro is that it can perform more complicated
> transformations on the format string, like this for example:
>
>         #define pr_fmt(fmt) "foo: %s():" fmt, __func__

OK, I figured you might want something like that.

>
> Thierry

Regards,
Simon