From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7844CC433EF for ; Thu, 14 Oct 2021 15:17:04 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5E1F60F4A for ; Thu, 14 Oct 2021 15:17:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E5E1F60F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 816278382F; Thu, 14 Oct 2021 17:13:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Neqlxo8J"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 098A6837A9; Thu, 14 Oct 2021 17:12:09 +0200 (CEST) Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F2DD1837C6 for ; Thu, 14 Oct 2021 17:12:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ot1-x32f.google.com with SMTP id l7-20020a0568302b0700b0054e40740571so8769297otv.0 for ; Thu, 14 Oct 2021 08:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1ZExeGsmM7yK6DsGBaYy1FKJ3+Brs4dvHIvtgwccocI=; b=Neqlxo8JDvnzbwRodbDPXdIHF61E8FHO0H3/gQke9XBE0eVWdh2XQMXbcXjY3JBcsb pDFuuE5altdkI0DIUTgoXgEVjowpouBTCZkeOcCFWEMmIxhgJeMr6w+uHoBH/MSwk8HH A2w8GkGK4yUogXNBrrPpHengKYRo2TQkvVf7A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1ZExeGsmM7yK6DsGBaYy1FKJ3+Brs4dvHIvtgwccocI=; b=fBrVD8r+dLg+zay48Tob3chDgiiJNrwA9xCHGXm2MbPG1EOMPjR1QJTNy++YIdoLcD jkOAl24Ty08fRcFUujE8AlxtnFvOojHFVp7RzOfWsMVSD+ilP449uBq7hSDBd+DJR0k+ ytigd4vQbf+ZMsDxxD1XzZIotReT6rvyyCsU2o5LjjPiK5+kTZp+ZDjPuIoXffJmE5qM HpcVqpcPBiq4RLQV+nqzAWkYpKO4YjPupZN5DGANtRbAnBc7hWXHK07s1mctWBCM5b1l j9qrX7jMIXDeFcvQwEnoxUZ5kcDxM1bDXqte5KhIw1Y8vA2c1dZkptlzWHfcZM/sg5+m /f1g== X-Gm-Message-State: AOAM532aL2N2RUrKWdnGUFTPngFsjcmMPq6O/qT6GbloLMwLDxAxXY84 XDu0FnZAEJkWL5HUEZyQ1pn0kAZSqrv2wexahdN4kg== X-Google-Smtp-Source: ABdhPJyg7CRqURWLdd2XV7TS0HVsSvyBgBg8x6WmnWJZaNaW+AMblhQDFbwsXRS0p1IU+ogFt3fjXGULv2FRAv6XlPw= X-Received: by 2002:a9d:7b49:: with SMTP id f9mr3088334oto.11.1634224321092; Thu, 14 Oct 2021 08:12:01 -0700 (PDT) MIME-Version: 1.0 References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-7-kabel@kernel.org> In-Reply-To: <20211013154557.28479-7-kabel@kernel.org> From: Simon Glass Date: Thu, 14 Oct 2021 09:11:11 -0600 Message-ID: Subject: Re: [PATCH v2 06/13] env: Check for terminating null-byte in env_match() To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > There is a possible overflow in env_match(): if environment contains > a terminating null-byte before '=3D' character (i.e. environment is > broken), the env_match() function can access data after the terminating > null-byte from parameter pointer. > > Example: if env_get_char() returns characters from string array > "abc\0def\0" and env_match("abc", 0) is called, the function will access > at least one byte after the end of the "abc" literal. > > Fix this by checking for terminating null-byte in env_match(). > > Signed-off-by: Marek Beh=C3=BAn > --- > Change since v1: > - check for '\0' only after incrementing i2 > --- > cmd/nvedit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass