From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] common: cli_hush: avoid memory leak
Date: Thu, 26 Nov 2015 18:52:01 -0800 [thread overview]
Message-ID: <CAPnjgZ24SzOn0zjxWTf9G0tv51jNEEfwegJa0wjVM65Sef5j_Q@mail.gmail.com> (raw)
In-Reply-To: <1448590322-14135-1-git-send-email-Peng.Fan@freescale.com>
On 26 November 2015 at 18:12, Peng Fan <Peng.Fan@freescale.com> wrote:
> Need to free memory avoid memory leak, when error.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>
> Changes V2:
> Take Simon's comments, fix another memory leak when child->argv is NULL.
> Add Simon's review tag.
>
> common/cli_hush.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Looks good!
- Simon
next prev parent reply other threads:[~2015-11-27 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 2:12 [U-Boot] [PATCH V2] common: cli_hush: avoid memory leak Peng Fan
2015-11-27 2:52 ` Simon Glass [this message]
2015-12-06 22:07 ` [U-Boot] [U-Boot,V2] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ24SzOn0zjxWTf9G0tv51jNEEfwegJa0wjVM65Sef5j_Q@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.