From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1406C433EF for ; Thu, 14 Oct 2021 15:15:33 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E4F060F4A for ; Thu, 14 Oct 2021 15:15:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3E4F060F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 55A93837DD; Thu, 14 Oct 2021 17:13:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="TNcLX2TX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E396D837BC; Thu, 14 Oct 2021 17:11:40 +0200 (CEST) Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CC0B583786 for ; Thu, 14 Oct 2021 17:11:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x22d.google.com with SMTP id n63so8881314oif.7 for ; Thu, 14 Oct 2021 08:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PejsgbZagUZFbXFTc2+vFIuwkouUisP4Hd+pi1h7jms=; b=TNcLX2TX9Rnj0UdIn5/AQbBiRoXigSQhuEVVDeAsppBql4qBiBeZ4ESwfd7KmgbC8f BLJ5hFmbsBgCONEThaN0V9bT0vMMyDZiFYaai/yPLZ55/umKYrLPsuqvp+Y1aVFnMjXo hCprWKLnQgq7xfNcdBi7Ui+rPeV5Ju2PAbvYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PejsgbZagUZFbXFTc2+vFIuwkouUisP4Hd+pi1h7jms=; b=ne+SwlrAZmVqvEtUf5B0+jgIaRbbcV99a9bbAYhfOA2FA0+3UUAuipQbmJ0heaK5qn DDK2Z3Gn5q7EmlbVrYTyK2N0EWFf/3I/yE7uL2KPZqWScL7MtTrKWIlnpBChxU0QaQ3d XK62pAJOQXrjsDYlCT0X/15MBcC7htloRuaIl6768Q8riX2Vk3Inx8Zs07EzVoSCp8vh /g68XRR8wgfalfdVAWp2INzR075/OnnykD7125SbBhkhyeKNqQ1efAkNvSekthijAmdE ag4Q8uQ7r3+/P2HGcP2wi8pjeyfJPj41R+VIHqcVqDYPp5DKBXszkEoY/CaXymJlVell wmqw== X-Gm-Message-State: AOAM533qFMh4D1fWtT+5wiihwk+dtBwS1JFbnbLNZn1cvEH+23FdpY3k IO3HzjAtm9pUT1E6GgPPxywFFHD2kIS1Tr+rpiZFvQ== X-Google-Smtp-Source: ABdhPJyRBCYtJegLkwvTZijF4cOHy761Z84UjDGCHjQ5/6qS5GwW7nvttfNGGfLs9LQRZo4P/Ie1HdZNA0+ZxRHBsUY= X-Received: by 2002:aca:4283:: with SMTP id p125mr12405445oia.81.1634224291100; Thu, 14 Oct 2021 08:11:31 -0700 (PDT) MIME-Version: 1.0 References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-11-kabel@kernel.org> In-Reply-To: <20211013154557.28479-11-kabel@kernel.org> From: Simon Glass Date: Thu, 14 Oct 2021 09:11:17 -0600 Message-ID: Subject: Re: [PATCH v2 10/13] env: Use better name for variable in env_get_f() To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > The `nxt` variable actually points to the terminating null-byte of the > current env var, and the next env var is at `nxt + 1`, not `nxt`. So a > better name for this variable is `end`. > > Signed-off-by: Marek Beh=C3=BAn > --- > cmd/nvedit.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass