From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1211C433F5 for ; Sat, 18 Sep 2021 12:14:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E80656127A for ; Sat, 18 Sep 2021 12:14:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E80656127A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4E7C682D85; Sat, 18 Sep 2021 14:14:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ccPoOgSq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 017FD82D85; Sat, 18 Sep 2021 14:14:01 +0200 (CEST) Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C2F9182BC3 for ; Sat, 18 Sep 2021 14:13:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vs1-xe34.google.com with SMTP id c28so11956202vsh.11 for ; Sat, 18 Sep 2021 05:13:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gvBxrxcSdROajrYfNxBVOqTx0LWmI8CaQbBfORVt6cg=; b=ccPoOgSqPFDWcN/xrncjpAubxhtvCOKnphgsjYvU2nrsKzv56P4zFxT9s8VWFg4e34 Ugsq55Bz+prIgn2wBl5pU+ORBukTela6Mfg7fIrqHCAyslJA78oH1/k5/HzY3ZmLEZ/s 8sDGBCbbliLU3JDHro+zk0fSIy2X0y7DUZD40= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gvBxrxcSdROajrYfNxBVOqTx0LWmI8CaQbBfORVt6cg=; b=SdDWW5ajRuTAHg9rAFjDNbGl5lMAQ07jeJl7gLb2imRpX4qIwAV/P/x+kHELM9kZNn +01xoOM6Q+9ao6Nsh3bBlEgymU7TZmHA4W4S48z+O+0P9xNDZIQ1C9phmRwcF4jJK5j2 zDpM3/kGaUEXLGCXeSdG8L5hcMxSfOPtP+PJn5Rf8sARrTsHRcwSLvq5wBPk+8BVObMR zJAQjAA+sSiMgi0pmG9w+PmZ8E2rJedDv724JenB7qvmy3zirhzq+foMMphLnDbvB2hS XlwOsS1Mn8F9EML7ZhOpdJa4nK6rVzslwDhUg5aSGYcc81aBRZ62u676+FbpjWI41zjX Xmkw== X-Gm-Message-State: AOAM531GSfVs9e0Ec8OXBFwTrpF0AIDS7fkojYjqqGa3sMvL3Z8aDC4o FVJIEOnpmft7QQMo5dMf8M4wPVZOr8t0EAhymeL2Fg== X-Google-Smtp-Source: ABdhPJwc9J1VchURfLMk+rSwwuyJnEdD+rnAHt4qu3U2TjF4lvCB76qsYj2+iselp68GHqTfnTpnMte6AwK+m4Ec3fA= X-Received: by 2002:a67:ee12:: with SMTP id f18mr12242271vsp.20.1631967235976; Sat, 18 Sep 2021 05:13:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Simon Glass Date: Sat, 18 Sep 2021 06:13:43 -0600 Message-ID: Subject: Re: Please pull u-boot-dm To: Ilias Apalodimas Cc: U-Boot Mailing List , Tom Rini , Heinrich Schuchardt , Mark Kettenis , =?UTF-8?Q?Fran=C3=A7ois_Ozog?= Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Ilias, On Sat, 18 Sept 2021 at 05:59, Ilias Apalodimas wrote: > > +cc a few people that had some input on that discussion. > Apologies from top posting, but I am sending this from a mobile. > > I think I've spent enough time trying to explain why I think we don't need to revert this and why moving the signature to the dtb once we fix it has minimal effect on the users. We could get a patch in the release which makes it clear that the current approach is temporary only and will change immediately after the release. But really I don't see any sense in that since it just confuses people. Better to drop it and get it done for next time. > > Note that the mkeficapsule is completely irrelevant and shouldnt be reversed anyway but since we have to make changes in documentation etc and we are close to a release, just keep it in there. > > If everyone is convinced that this needs to be reverted I am fine. I'll just refix all of the platforms(since with this reverted only qemu supports authenticated capsules) and have a look on the dtb issues. Yes and I am very happy to work with you on that. Regards, Simon > > Regards > Ilias > > On Sat, 18 Sep 2021, 14:34 Simon Glass, wrote: >> >> Hi Tom, >> >> This is a revert of the EFI patches as mentioned on the mailing list. >> I believe this is the best way forward and avoids the current, flawed >> approach from getting into an official release and making it difficult >> to back out. >> >> >> https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/9154 >> >> >> >> The following changes since commit d0b8c9a231d6e5fba881960c9fcfcc444f1812f9: >> >> Merge branch '2021-09-17-TI-platform-updates' (2021-09-17 18:51:57 -0400) >> >> are available in the Git repository at: >> >> git@source.denx.de:u-boot/custodians/u-boot-dm.git tags/dm-pull-18sep21 >> >> for you to fetch changes up to 47a25e81d35c8d801cae9089de90c9ffea083409: >> >> Revert "efi_capsule: Move signature from DTB to .rodata" (2021-09-18 >> 03:47:50 -0600) >> >> ---------------------------------------------------------------- >> Revert the public-key-embedded-in-executable patches so this does not form >> part of an official release before it is agreed. >> >> ---------------------------------------------------------------- >> Simon Glass (3): >> Revert "doc: Update CapsuleUpdate READMEs" >> Revert "mkeficapsule: Remove dtb related options" >> Revert "efi_capsule: Move signature from DTB to .rodata" >> >> board/emulation/common/Makefile | 1 + >> doc/develop/uefi/uefi.rst | 124 ------------------------------ >> include/asm-generic/sections.h | 2 - >> lib/efi_loader/Kconfig | 7 -- >> lib/efi_loader/Makefile | 8 -- >> lib/efi_loader/efi_capsule.c | 18 +---- >> lib/efi_loader/efi_capsule_key.S | 17 ----- >> tools/mkeficapsule.c | 229 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++-- >> 8 files changed, 226 insertions(+), 180 deletions(-) >> delete mode 100644 lib/efi_loader/efi_capsule_key.S >> >> >> Regards, >> Simon