From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9213EC433F5 for ; Fri, 5 Nov 2021 02:04:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F4D061056 for ; Fri, 5 Nov 2021 02:04:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0F4D061056 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D8DF83746; Fri, 5 Nov 2021 03:03:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="RcjTmXo6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0171D83686; Fri, 5 Nov 2021 03:03:04 +0100 (CET) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2E3AB83712 for ; Fri, 5 Nov 2021 03:02:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x22c.google.com with SMTP id bk26so11069627oib.11 for ; Thu, 04 Nov 2021 19:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UKHk0bD48gpsfLj6q7UOSW3RWGpfu2wyQYAJIi7i4Vo=; b=RcjTmXo6GvprOnEJq/3dcGgtvVaHfJiHqXiWYDoq8uShSmG8Nm7AfviYyLVJGWMl77 BsZoVcopLpwXVx7gmC9fiKHUyZf0/pPzGoSa+Vve57Px98JZ66zqdi7F4g6QHgCGvJts aaCx6srkxoQ8EGyKiOajOGZATULP73ysOP0qQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UKHk0bD48gpsfLj6q7UOSW3RWGpfu2wyQYAJIi7i4Vo=; b=WzdZz1qgkc0ul/UT9hb1QYrO3ow9MVfDXH6jMhBtoaD6R4ozt8wN8Cgq3jBD33Z+/u iZ0o1SZdBDqZNvk0g5TBDD0qFTCgRIBREdYOA34drPyecNIMZ1XAG35u+tFJf9u5ZLNM HmUJ5sqAyV34WNcicewqCO/wD8qiLBfTh6Sd13KTv1FW5HaH/4/2S7kldF4fpAgwxnEC 6ZaA1m8hVCo9S84fN5wPXhVtiVp2YvWz1aLPdXyFp4MHnNqFQPzjXbPDkZRkda3AiZuO JTD0fXtx6mmAheCxjyrRbH4HD1xwHGaIS94stUfJOYDUApUXyvLRyKNWBCnkEY+UyEXz 0sVA== X-Gm-Message-State: AOAM532CI+KArmnShc2tqMEvYQwAuSThtYc4zOWJyhSM01nGZcEiRIb9 Kwpw/+f/J1UZBdhSxwc2b/CXebDmjTa6DEpkveX6gQ== X-Google-Smtp-Source: ABdhPJwaiVGrhjJHG+sjs1+asgExYkrmka7OBpEBbyxrZvL9pVY8FIRp5BLNFOZK0mqiLtqQ2E0b12KUWouelsxuP7E= X-Received: by 2002:aca:4183:: with SMTP id o125mr19482271oia.53.1636077764514; Thu, 04 Nov 2021 19:02:44 -0700 (PDT) MIME-Version: 1.0 References: <20211103232332.2737-1-kabel@kernel.org> <20211103232332.2737-10-kabel@kernel.org> In-Reply-To: <20211103232332.2737-10-kabel@kernel.org> From: Simon Glass Date: Thu, 4 Nov 2021 20:02:30 -0600 Message-ID: Subject: Re: [PATCH v2 09/12] env: Change return behaviour of env_set_default_vars() To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: =?UTF-8?Q?Pali_Roh=C3=A1r?= , u-boot@lists.denx.de, =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 3 Nov 2021 at 17:23, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > The env_set_default_vars() function does not document return value and > behaves differently from other env_* functions. > > Change the return value to return 0 on success and -ve on error. > > Signed-off-by: Marek Beh=C3=BAn > --- > env/common.c | 9 ++++++--- > include/env.h | 1 + > 2 files changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass