From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ADC0C433F5 for ; Sun, 24 Oct 2021 19:58:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A645460EDF for ; Sun, 24 Oct 2021 19:58:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A645460EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C2CF7835B9; Sun, 24 Oct 2021 21:56:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="hZ59wBzP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C3B1783460; Sun, 24 Oct 2021 21:54:38 +0200 (CEST) Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9460583461 for ; Sun, 24 Oct 2021 21:54:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ot1-x32a.google.com with SMTP id d21-20020a9d4f15000000b0054e677e0ac5so11900886otl.11 for ; Sun, 24 Oct 2021 12:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dMdkJNVUBOWi1iLs+17p0zu3dUUP3fO2MzX6DTuECgA=; b=hZ59wBzPP6DDkakzycfMC7Rs3ZKOeNbqfLmaOy7GaiO185b+KF5dcxL6QbHkeImTtj 3FRcurdSNOBZ7plFMrPQFnjCpqR6s5+zBHoQBEu2IoVhErAm1801Eilwzpz6I21gGyHv uc7IMV4HWJw5FCuArLnzzo77L3xUk+liKLH/A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dMdkJNVUBOWi1iLs+17p0zu3dUUP3fO2MzX6DTuECgA=; b=64n1iFwOKCSQ82Epcbb4K374cLi4Jgaz5S+tSw0DWlR2UOnpdHMXdk18+/VXpMpltl Jv2+CgqawGLxPLDAe3qWcdq6POnIu6/WZ1V+lgr2+uPL2mqJB1qEyQghCD1fYpsefv0/ a1N/aqxK0eRxM8RtK/J0BEL/fSeenz7sQkHl/H+D9JerfVexYOer2aO1ZAKEwvFhmLuT xkUH3GNDgqa+kTF4aiQCgOr0SQflFP6JiYAxHW6RJhg8P1MIQ0aEu4DH9HFpeVpv522m u4m5PMtabTDKKitrFKmHxku0/iyDw2TdxrW4zWhuI4Xp1cvAFM6cJZJYE+XiBf4rNEIO ZuLw== X-Gm-Message-State: AOAM532JzWINfQfa8R/gbYZowdpmXwdrE7NSgv28uw5P1Rr1JHe6Sf+X L/u0l2+01E+djM9k6BfVxglU3Qq1S7J0siG94hW97g== X-Google-Smtp-Source: ABdhPJxbUtdGTITZEHDHSafIupRCXb9SVh4khK8HfIs8WDJBgaeozX7pevtalsShYpvrIpKTL7N8DLWxvtFpXOiCDkA= X-Received: by 2002:a9d:17c5:: with SMTP id j63mr10642636otj.191.1635105270012; Sun, 24 Oct 2021 12:54:30 -0700 (PDT) MIME-Version: 1.0 References: <20211022030852.1986718-1-sjg@chromium.org> <20211022030852.1986718-7-sjg@chromium.org> In-Reply-To: From: Simon Glass Date: Sun, 24 Oct 2021 13:54:17 -0600 Message-ID: Subject: Re: [PATCH v10 8/9] sandbox: Update the test MAC/IP addresses To: Heinrich Schuchardt Cc: U-Boot Mailing List , Wolfgang Denk , u-boot-board-maintainers@lists.denx.de, Rasmus Villemoes , u-boot-custodians@lists.denx.de, Tom Rini , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Alexander Dahl Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Sat, 23 Oct 2021 at 02:30, Heinrich Schuchardt wrote: > > > > On 10/22/21 05:08, Simon Glass wrote: > > These conflict with real-word addresses. Use locally administered > > MAC addresses and a suitable IPv4 address from 192.0.2.0/24 > > (TEST-NET-1). > > > > Signed-off-by: Simon Glass > > Suggested-by: Alexander Dahl > > --- > > > > Changes in v10: > > - Add new patch to update the test MAC/IP addresses > > > > board/sandbox/sandbox.env | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/board/sandbox/sandbox.env b/board/sandbox/sandbox.env > > index 0f8d95b8db0..b4c04635a48 100644 > > --- a/board/sandbox/sandbox.env > > +++ b/board/sandbox/sandbox.env > > @@ -5,13 +5,13 @@ stdin+=,cros-ec-keyb,usbkbd > > stdout=serial,vidconsole > > stderr=serial,vidconsole > > > > -ethaddr=00:00:11:22:33:44 > > -eth2addr=00:00:11:22:33:48 > > -eth3addr=00:00:11:22:33:45 > > -eth4addr=00:00:11:22:33:48 > > -eth5addr=00:00:11:22:33:46 > > -eth6addr=00:00:11:22:33:47 > > -ipaddr=1.2.3.4 > > +ethaddr=02:00:11:22:33:44 > > +eth2addr=02:00:11:22:33:48 > > +eth3addr=02:00:11:22:33:45 > > +eth4addr=02:00:11:22:33:48 > > Ethernet addresses should be unique. > > Should it be on purpose that two Ethernet address are the same, please > add a comment in the code. Can you please explain what you are getting out here? Which ones are not unique? > > +eth5addr=02:00:11:22:33:46 > > +eth6addr=02:00:11:22:33:47 > > +ipaddr=192.0.2.1 > > > > /* > > * These are used for distro boot which is not supported. But once bootmethod > > Regards, Simon