All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] regmap: clean up regmap allocation
Date: Sun, 22 Apr 2018 20:11:27 +0000	[thread overview]
Message-ID: <CAPnjgZ2BH2aBsrfXqeXUpnuVLLPir8cNJ1cvre6J-C=OJnOPGA@mail.gmail.com> (raw)
In-Reply-To: <1524019125-26287-2-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro,

On 17 April 2018 at 20:38, Masahiro Yamada <yamada.masahiro@socionext.com>
wrote:
> Putting zero length array at the end of struct is a common technique
> to embed arbitrary length of members.  There is no good reason to let
> regmap_alloc_count() branch by "if (count <= 1)".
>
> As far as I understood the code, regmap->base is an alias of
> regmap->ranges[0].start, but it is not helpful but make the code
> just ugly.
>
> Rename regmap_alloc_count() to regmap_alloc() because the _count
> suffix seems pointless.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/core/regmap.c | 31 +++++++++----------------------
>  include/regmap.h      |  7 ++-----
>  2 files changed, 11 insertions(+), 27 deletions(-)

This seems fine to me and does not increase the number of allocations.

Reviewed-by: Simon Glass <sjg@chromium.org>

Regards,
Simon

  reply	other threads:[~2018-04-22 20:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18  2:38 [U-Boot] [PATCH 0/4] Add Linux-compatible syscon_to_regmap API Masahiro Yamada
2018-04-18  2:38 ` [U-Boot] [PATCH 1/4] regmap: clean up regmap allocation Masahiro Yamada
2018-04-22 20:11   ` Simon Glass [this message]
2018-04-18  2:38 ` [U-Boot] [PATCH 2/4] dm: ofnode: add ofnode_device_is_compatible() helper Masahiro Yamada
2018-04-22 20:11   ` Simon Glass
2018-04-23  4:50     ` Masahiro Yamada
2018-04-25  5:01       ` Simon Glass
2018-04-18  2:38 ` [U-Boot] [PATCH 3/4] regmap: change regmap_init_mem() to take ofnode instead udevice Masahiro Yamada
2018-04-18 15:34   ` Neil Armstrong
2018-04-22 20:10   ` Simon Glass
2018-04-23  4:56     ` Masahiro Yamada
2018-04-25  5:01       ` Simon Glass
2018-04-18  2:38 ` [U-Boot] [PATCH 4/4] syscon: add Linux-compatible syscon API Masahiro Yamada
2018-04-22 20:11   ` Simon Glass
2018-04-23  4:58     ` Masahiro Yamada
2018-04-25  5:01       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ2BH2aBsrfXqeXUpnuVLLPir8cNJ1cvre6J-C=OJnOPGA@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.