All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 1/3] sandbox: add handler for exceptions
Date: Wed, 11 Nov 2020 16:11:05 -0700	[thread overview]
Message-ID: <CAPnjgZ2C+1j3SSpjZr2B3WJ4nmw2uu6+N5jHv2Z1YvN0+UhUxg@mail.gmail.com> (raw)
In-Reply-To: <e94c46af-9310-f17f-3c93-283acee81b4d@gmx.de>

Hi Heinrich,

On Wed, 11 Nov 2020 at 13:47, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 11.11.20 15:32, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Tue, 10 Nov 2020 at 16:09, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >>
> >> Add a handler for SIGILL, SIGBUS, SIGSEGV.
> >>
> >> When an exception occurs print the program counter and the loaded
> >> UEFI binaries and reset the system.
> >>
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >> ---
> >>  arch/sandbox/cpu/os.c         | 31 +++++++++++++++++++++++++++++++
> >>  arch/sandbox/cpu/start.c      |  4 ++++
> >>  arch/sandbox/lib/interrupts.c | 30 ++++++++++++++++++++++++++++++
> >>  include/os.h                  | 17 +++++++++++++++++
> >>  4 files changed, 82 insertions(+)
> >
> > Generally we want to stop execution, because it indicates a bug. Then
> > we might want to run it again with gdb to debug it.
> >
> > So I think this feature should be enabled by a flag.
> >
> > Regards,
> > Simon
> >
>
> I understand that if I call os_launch should be customizable.
>
> Providing the output should be helpful in any case.

I'm not sure what you mean here, but what I am saying is that by
default sandbox should crash. We don't really want the caller to have
to kill it if a test fails, etc.

Regards,
Simon

  reply	other threads:[~2020-11-11 23:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 23:09 [PATCH 0/3] sandbox: exception handling Heinrich Schuchardt
2020-11-10 23:09 ` [PATCH 1/3] sandbox: add handler for exceptions Heinrich Schuchardt
2020-11-11 14:32   ` Simon Glass
2020-11-11 20:47     ` Heinrich Schuchardt
2020-11-11 23:11       ` Simon Glass [this message]
2020-11-10 23:09 ` [PATCH 2/3] cmd: sandbox: implement exception command Heinrich Schuchardt
2020-11-11 14:32   ` Simon Glass
2020-11-10 23:09 ` [PATCH 3/3] efi_selftest: implement exception test for sandbox Heinrich Schuchardt
2020-11-11 14:32   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ2C+1j3SSpjZr2B3WJ4nmw2uu6+N5jHv2Z1YvN0+UhUxg@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.