From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sat, 14 Jan 2017 10:14:10 -0700 Subject: [U-Boot] [PATCH 07/12] aspeed/ast2500: Helper function to get access to SCU In-Reply-To: <20170104194656.124368-8-maxims@google.com> References: <20170104194656.124368-1-maxims@google.com> <20170104194656.124368-8-maxims@google.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Maxim, On 4 January 2017 at 12:46, Maxim Sloyko wrote: > Helper function to get access to SCU (System Control Unit) through Clock > driver. This is similar to rockchip_get_cru function, which was used as > an example. > > It will be used by other drivers to get access to SCU. > > Signed-off-by: Maxim Sloyko > --- > > arch/arm/mach-aspeed/Kconfig | 2 ++ > arch/arm/mach-aspeed/Makefile | 1 + > arch/arm/mach-aspeed/ast2500/Kconfig | 6 ++++++ > arch/arm/mach-aspeed/ast2500/Makefile | 1 + > arch/arm/mach-aspeed/ast2500/clk_ast2500.c | 31 ++++++++++++++++++++++++++++++ > 5 files changed, 41 insertions(+) > create mode 100644 arch/arm/mach-aspeed/ast2500/Kconfig > create mode 100644 arch/arm/mach-aspeed/ast2500/Makefile > create mode 100644 arch/arm/mach-aspeed/ast2500/clk_ast2500.c The code seems fine. It seems odd that you have Kconfig changes here also. Why is that? Regards, Simon