From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A09EECAAD2 for ; Tue, 30 Aug 2022 02:32:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E6080849CA; Tue, 30 Aug 2022 04:31:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="l6L/OQoD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 94D4B849AB; Tue, 30 Aug 2022 04:31:48 +0200 (CEST) Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7DDB88494C for ; Tue, 30 Aug 2022 04:31:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-33da3a391d8so241172757b3.2 for ; Mon, 29 Aug 2022 19:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=f91+jp3/G/nJAmPRvrVZoAskKhbTw0nNy4sGNTlA4BM=; b=l6L/OQoDGBcJ2MDq2Z9tFVUAKu6yTvjt43Ts7/UVw7CaYaRt8WI9TFNOkrEZygK5xK G9pHi3vl9lZed3GMnpp81O/uvL1cMqV3E2FUqRtwrZyexQXhVZ7Jdx12GG/jWxe5O61P udfx7S/Y9EwxtLYRDwDpq+1AyFgsyAcDW+ke4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=f91+jp3/G/nJAmPRvrVZoAskKhbTw0nNy4sGNTlA4BM=; b=gKEgjvz4XrLwP6R5cJ4nqmhhjddn5SjQeDof4Wb4cPgj78HxzeSC/Y55K6Wwc2wdis YcjVDyHY0hvyEFfgdZDfcjUtS7V9e2e+ohawGofy9GUTIoZkEVzyFo8ezFAC8Jw5pxEN nSL5o/jsWa4jMvFEm7XSE8Wm+xYAFxmjtQyYECuX2NXVpTj400HWTRGOFcpXtogQ6ipK AcQoqvPspAWFThSU6uaTFrIHicvOQlK49/EGjhpIxqFLrMaDn81/6hbZxqcn4yqarRlB aQ9V+Zw+uGhAeYfe9FV6nFmv3tNce4FtF2ygYwWEaERQi0kYl5yrEpwxSHpKfTmnc0BX Hqhg== X-Gm-Message-State: ACgBeo2FsqhWl56Dd1/h68ElSD85IRCRVHBVCcwEnx85RaQeXA5El3Lm 7a8XDZWi3iVSik4GaM3NVB7f3FUazPBBcGICoYS/iw== X-Google-Smtp-Source: AA6agR5gmZNQtzN8oItVH+lDjUup+aiHirovUo4VhUfXoBRCLwrqZoQXYxqwkaSf1Ulk02RiK9aGWfwwkavydeX0NzA= X-Received: by 2002:a81:6c56:0:b0:33d:cbb1:95e5 with SMTP id h83-20020a816c56000000b0033dcbb195e5mr12059710ywc.423.1661826705072; Mon, 29 Aug 2022 19:31:45 -0700 (PDT) MIME-Version: 1.0 References: <20220829062313.32654-1-sr@denx.de> <20220829062313.32654-2-sr@denx.de> In-Reply-To: <20220829062313.32654-2-sr@denx.de> From: Simon Glass Date: Mon, 29 Aug 2022 20:31:33 -0600 Message-ID: Subject: Re: [RFC PATCH 1/8] cmd/cyclic: Use div64 macros for division and remainder To: Stefan Roese Cc: U-Boot Mailing List , Tom Rini , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, 29 Aug 2022 at 00:23, Stefan Roese wrote: > > Use the do_div etc for divisions to fix the compile breakage seen on > edison: > > cmd/cyclic.c:70: undefined reference to `__udivmoddi4' > > and for e.g. MIPS netgear_cg3100d_ram: > > cmd/cyclic.c:(.text.do_cyclic_list+0x180): undefined reference to `__umoddi3' > > Signed-off-by: Stefan Roese > --- > cmd/cyclic.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass