From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B1BC433F5 for ; Mon, 18 Oct 2021 18:13:11 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A8A26128E for ; Mon, 18 Oct 2021 18:13:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7A8A26128E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0C74B82C7D; Mon, 18 Oct 2021 20:12:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="MLD2xMyt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 90D7882DB7; Mon, 18 Oct 2021 20:12:35 +0200 (CEST) Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 47DBB8119C for ; Mon, 18 Oct 2021 20:12:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92b.google.com with SMTP id a17so3940526uax.12 for ; Mon, 18 Oct 2021 11:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EJo12xOAAhYfHV4/1w0Kelsin666CvapQ86m4Jk/gwg=; b=MLD2xMytsYuYcwOee5czsI/nOrJr5w2rxozbPtluVCJ/LndsaRDjpiZphJdncranPr jnQ+Gm85gCcWbV+qHJjZlZ3I2+BvCrRCfn6f7H8GGO1uNR6/mk9Bw4VD52ocMvKnGKpt fhfY9KeOQhoQu6JM1rnBJeLixWUtvXMfHAiPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EJo12xOAAhYfHV4/1w0Kelsin666CvapQ86m4Jk/gwg=; b=zdo1dLUcMkdCeGcr7BRPTAqygWTpTzi6u7qMJY2thcLOUCx+7bpNeXAajIGkzeD6Hw k3gCrBxHytXHmTQK0RxOurehcSDLk7JnjE1XzTqZLPhRAcy3GYiOrn8v29d6zTpCkKjs Z83bgBNkOkhiMo48+qacw5T95m0bnlRoAfIrmG1T0VUMmTWLg09hOWpOstVDXJ3Jt7L3 JSE04uPW3x2PL5+GiptUrIHPa7cQiNjVHf5LDNvZC/PKfuDHNLRYah6PhPpsYI6HSPj5 aqCJ1yycsadTDCPaMW8uhPihVlvBCL3mqFuzUI50EYt55m1uMY3oQO4SFlbDpdbyaf2k p/OQ== X-Gm-Message-State: AOAM533LzrcTlHHNtBVLWBduPnwNGkB8Ce7tR3UVguF5STzEDvGhN70E Djg7aO/aFJv7PWaWeNXhY4bZP+Wf2afMW4CzsCTp6A== X-Google-Smtp-Source: ABdhPJzU0ngkduwOI+TH6l9pq1Cipscn3W/z7AVyQRv9LLKGEnCwmK73jSfFFQN50JM5RNi6nCSaHP2wZeKxknrinNc= X-Received: by 2002:ab0:14a7:: with SMTP id d36mr27254524uae.96.1634580747641; Mon, 18 Oct 2021 11:12:27 -0700 (PDT) MIME-Version: 1.0 References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> <3496103.1634558337@gemini.denx.de> <20211018133728.GQ7964@bill-the-cat> <3502270.1634566234@gemini.denx.de> In-Reply-To: <3502270.1634566234@gemini.denx.de> From: Simon Glass Date: Mon, 18 Oct 2021 12:12:16 -0600 Message-ID: Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file To: Wolfgang Denk Cc: Tom Rini , U-Boot Mailing List , Heinrich Schuchardt , Joe Hershberger Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Wolfgang, On Mon, 18 Oct 2021 at 08:10, Wolfgang Denk wrote: > > Dear Tom, > > In message <20211018133728.GQ7964@bill-the-cat> you wrote: > > > > > And please see also my comments about changing the autostart > > > functionality for the user. > > > > Perhaps we should just make "+" an illegal character in the variable > > name, for consistency? > > And break backward compatibility? I'd rather see a better > definition of the syntax of the environment files, plus maybe a more > powerful parser. > > I mean, there is no technical reason to forbid the '+' character - > and then it's only at the end of the variable name. > > Hm... I can't find it right now but did I not also read about other > restrictions to variable names, like they must noch begin with '_' > when using this new tool? Yes but I took that out (I think in v6). I'll update the commit message. > > > I feel it is wrong to place new restrictions on something that was > constant for 21 years, just because our parser cannot parse it... We need the + thing and perhaps we should ask people to avoid punctuation, etc? But for now I'm not requiring it in this series, apart from + Regards, Simon