From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A673C53210 for ; Sun, 8 Jan 2023 16:20:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0D6A685548; Sun, 8 Jan 2023 17:20:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="bqppuHRI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 03797855EA; Sun, 8 Jan 2023 17:20:25 +0100 (CET) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0A945854DB for ; Sun, 8 Jan 2023 17:20:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ej1-x62e.google.com with SMTP id cf18so8217399ejb.5 for ; Sun, 08 Jan 2023 08:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4vsxaZ23BIZoCxogJYOQnNJUvZMMXR06/92CEg9xb60=; b=bqppuHRIgwV8jJQX2cscpRKvQhPTS/o2dGt1C7oYAaoKduEC4nq9RU1hGn95Yiua6E 9hZozPdhcxuPT2zfd4/BWjy+eP/mf4M86T6IlObvNNKJ49iTLppHk5ytRZkxuiOvVkdk wnPg8ZQzpIiURTWqlvCWimmhTEGkfzrlMRmMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4vsxaZ23BIZoCxogJYOQnNJUvZMMXR06/92CEg9xb60=; b=bMUKyHa1IE9KyBZxxibNItQqVkXMhFMiqdNjMRyyzRapK03oFt8dQjBfI9dJdIclMm /EBMYGfu/iEgIrgx6oh/OBMP57kbf02aOCZ1dg4sZFThYQvzU7Gv2WMhLQobD2O8SeLR 1eK77H5Ut+2Tco+rXZ2uahaNX4Z+p5ymWzpOnciUwFOp7zPZUWfiAltEcKoIGG0zZ+CA Lgx/Xrllrrj6nH5YUoOqiuxz8L0zNqXEnb9Muy4X9gD0ZXVrYP0dLqxyVTwicYAyX2SD HXWJ0uU7H0W18ASFtspCjUZtSMi805ffzbQTowwuwLrz0HbI82PafTnE3OWBLPS/qtQK NyYg== X-Gm-Message-State: AFqh2koMmc/wLfT9OqxBLgSl3ykP/6o871391AK090gS4Wecx5RdXhj5 2ommY3ZpBOS3dSBf2zAyWexbMFHRs3mRkY/gzadPFQ== X-Google-Smtp-Source: AMrXdXtGZ3RkF+GC9yYX6/FzGMRPC0+uiOrqmlXk7fDrEtjAJFPSf0UlhGHBviDVbQ0hJSKqkTpAzsemmvO9ISSFLuE= X-Received: by 2002:a17:906:2857:b0:82d:1b76:1e44 with SMTP id s23-20020a170906285700b0082d1b761e44mr4629553ejc.93.1673194821393; Sun, 08 Jan 2023 08:20:21 -0800 (PST) MIME-Version: 1.0 References: <20230107210721.478062-1-sjg@chromium.org> <20230107210721.478062-15-sjg@chromium.org> <20230108134132.GY3787616@bill-the-cat> <20230108160605.GB3787616@bill-the-cat> In-Reply-To: <20230108160605.GB3787616@bill-the-cat> From: Simon Glass Date: Sun, 8 Jan 2023 09:20:09 -0700 Message-ID: Subject: Re: [PATCH v9 14/14] treewide: Disable USE_SPL_FIT_GENERATOR by default To: Tom Rini Cc: Michal Simek , Luca Ceresoli , U-Boot Mailing List , Roger Quadros , Alper Nebi Yasak , Peter Geis , Jerome Forissier , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , Ivan Mikhaylov , Quentin Schulz , Philippe Reynes Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Sun, 8 Jan 2023 at 09:06, Tom Rini wrote: > > On Sun, Jan 08, 2023 at 08:48:37AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Sun, 8 Jan 2023 at 06:41, Tom Rini wrote: > > > > > > On Sat, Jan 07, 2023 at 02:07:21PM -0700, Simon Glass wrote: > > > > > > > This option is deprecated and only used by two boards. Enable it for just > > > > those two boards, so others don't accidentally enable it. > > > > > > > > Signed-off-by: Simon Glass > > > [snip] > > > > diff --git a/boot/Kconfig b/boot/Kconfig > > > > index 55f06761ef8..7ab0dd14211 100644 > > > > --- a/boot/Kconfig > > > > +++ b/boot/Kconfig > > > > @@ -282,12 +282,13 @@ config SPL_FIT_SOURCE > > > > config USE_SPL_FIT_GENERATOR > > > > bool "Use a script to generate the .its script" > > > > depends on SPL_FIT > > > > - default y if SPL_FIT && ARCH_ZYNQMP > > > > + help > > > > + This is deprecated. Please do not use it. Use binman instead. > > > > > > Lets remove the text around bool so it can't be enabled, and move to > > > select'ing it from the two boards that need it. Michal, Luca, what's > > > needed to move your two platforms > > > (avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0 and xilinx_zynqmp_virt off > > > of this very legacy option, given that other xilinx platforms have > > > already migrated to binman ? > > > > That's a good idea, but these two boards do not have TARGET Kconfig > > options so it is not possible without adding some Kconfig specific to > > those boards, then defining it in the defconfig files. > > > > We already have the legacy warning. > > Yes, but I swear these are new legacy users as when we started trying to > kill off this option it was just a few i.MX platforms lagging behind. > > Maybe make ARCH_ZYNQMP select DEPRECATED, USE_SPL_FIT_GENERATOR depend > on DEPRECATED and add "DERECATED" to the end of the text line? Or maybe > Michal or Luca will speak up soon and migrate these over quickly so we > can just nuke this. Isn't that just more tortuous? I can disable SPL_LOAD_FIT on these two boards since they don't appear in CI. Then they can convert them when ready. That way we can drop the option now, if that is your goal. Regards, Simon