From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Mon, 10 Dec 2018 18:07:26 -0700 Subject: [U-Boot] [PATCH v2 2/8] fdt: parse "reserved-memory" for memory reservation In-Reply-To: References: <20181117091818.15393-1-simon.k.r.goldschmidt@gmail.com> <20181117091818.15393-3-simon.k.r.goldschmidt@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On Thu, 29 Nov 2018 at 13:40, Simon Goldschmidt wrote: > > On 27.11.2018 06:40, Simon Goldschmidt wrote: > > On Tue, Nov 27, 2018 at 2:02 AM Simon Glass wrote: > >> Hi Simon, > >> > >> On Sat, 17 Nov 2018 at 02:18, Simon Goldschmidt > >> wrote: > >>> boot_fdt_add_mem_rsv_regions() adds reserved memory sections to an lmb > >>> struct. Currently, it only parses regions described by /memreserve/ > >>> entries. > >>> > >>> Extend this to the more commonly used scheme of the "reserved-memory" > >>> node. > >>> > >>> Signed-off-by: Simon Goldschmidt > >>> --- > >>> > >>> Changes in v2: > >>> - this patch is new in v2 > >>> > >>> common/image-fdt.c | 52 +++++++++++++++++++++++++++++++++++++++------- > >>> 1 file changed, 44 insertions(+), 8 deletions(-) > >> Reviewed-by: Simon Glass > >> > >> But it would be nice to convert this to livetree. > > OK, let me try that ;-) > > So I tried to convert to livetree but since the function > 'boot_fdt_add_mem_rsv_regions' is used on devicetrees loaded to boot > Linux, I can't really change it (the 'of' functions use gd->fdt_addr' as > fallback, which is wrong in that case). > > Converting to livetree for the new usecases ('load' and 'tftp' commands) > would be possible, but would result in code duplication. > > What do you think? Yes I understand. We don't have a livetree version of the setprop APIs. Regards, Simon