All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] x86: move arch-specific asmlinkage to <asm/linkage.h>
Date: Tue, 9 Dec 2014 22:12:42 -0700	[thread overview]
Message-ID: <CAPnjgZ2FxByfehoBehcQ0C0kpzKDCjdeSz1XkbXbwuTxcmBDRA@mail.gmail.com> (raw)
In-Reply-To: <20141208110114.166C.AA925319@jp.panasonic.com>

Hi Tom,

On 7 December 2014 at 19:01, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> Hi Simon,
>
> On Sun, 7 Dec 2014 14:44:21 -0700
> Simon Glass <sjg@chromium.org> wrote:
>
>> >  #endif
>> > diff --git a/arch/x86/include/asm/linkage.h b/arch/x86/include/asm/linkage.h
>> > new file mode 100644
>> > index 0000000..bdca72e
>> > --- /dev/null
>> > +++ b/arch/x86/include/asm/linkage.h
>> > @@ -0,0 +1,6 @@
>> > +#ifndef _ASM_X86_LINKAGE_H
>> > +#define _ASM_X86_LINKAGE_H
>> > +
>> > +#define asmlinkage CPP_ASMLINKAGE __attribute__((regparm(0)))
>>
>> Why CPP_ASMLINKAGE here?
>
>
> The intention of the generic asmlinkage (defined in <linux/linkage.h>)
> is to add 'extern "C"' if __cplusplus is defined.
> The x86-specific asmlinkage should be supposed to add "__attribute__((regparm(0)))"
> onto that rather than replacing it.
>
>
>>
>> Tested on chromebook_link:
>>
>> Tested-by: Simon Glass <sjg@chromium.org>
>>
>> With the above question answered, I'd like to apply this as it is a
>> clean-up. Is it OK to so this independently of the ARM patch?
>
>
> It must be accompanied with the ARM patch, otherwise the latter
> will get a conflict.
>
> Will you apply both to u-boot-x86?
> I think it is OK because 2/2 is trivial enough.

Do you agree with this?

Regards,
Simon

  reply	other threads:[~2014-12-10  5:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03  8:36 [U-Boot] [PATCH 0/2] Consolidate asmlinkage defines Masahiro Yamada
2014-12-03  8:36 ` [U-Boot] [PATCH 1/2] x86: move arch-specific asmlinkage to <asm/linkage.h> Masahiro Yamada
2014-12-07 21:44   ` Simon Glass
2014-12-08  2:01     ` Masahiro Yamada
2014-12-10  5:12       ` Simon Glass [this message]
2014-12-15 18:26         ` Simon Glass
2014-12-03  8:36 ` [U-Boot] [PATCH 2/2] ARM: remove redundant asmlinkage define Masahiro Yamada
2014-12-15 18:27   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ2FxByfehoBehcQ0C0kpzKDCjdeSz1XkbXbwuTxcmBDRA@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.