From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86614C433F5 for ; Sat, 22 Jan 2022 17:18:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 36E6D83854; Sat, 22 Jan 2022 18:17:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="e6PSpF6l"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3F8BA835C8; Sat, 22 Jan 2022 18:17:31 +0100 (CET) Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4E4ED83065 for ; Sat, 22 Jan 2022 18:17:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x92a.google.com with SMTP id b37so5151509uad.12 for ; Sat, 22 Jan 2022 09:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=szV9Vps4WWafxHfQy2zN4znUeN2VEZuGq9M1Ab1BHlg=; b=e6PSpF6loOK6VjEapk0R55F6GUc8OI+XOyg2xdirJte+xafIzFjqZ8QGiWHTWctEtS vNxSWTl1rrfNXVDpgbIdmlgRIGRKYjM29j+5gQj2qhOhyahLELV3OVtJ+qg9J1a1kwwX fHPrdves7FgfILoXbs4M989CNEYxMtNraBbR0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=szV9Vps4WWafxHfQy2zN4znUeN2VEZuGq9M1Ab1BHlg=; b=t27JrLca6dhxDh+BG8frvv7tRUPTpgmIgZzxjWYDBbYnnmq86iGdE8camXH7ZMMMSN CuhgYyGeeYsBpJFanO7rZdTNCFQ/mPAXL7CTRIE9rsy69vXlZdZccBv/k0iK9e7fQXTp Z2JLpI//zhDs7cxwYnIzLib/WtYSX6EFpSSJ0tbIQNzFFosn58NVjzPkBx+ayN4HbHZH idfgDvTACGwle5tGp1gPvgEBjTmeTvBmuCAK1Opvct3oPZtYQHUeJFl8Sft3OTJiLZIo Loux+kmf35yAIe3RuvsV4pOLmgUHQtsmpvvCk0+ZcP01oyzWSlnBWCumQhyVFl4Goxc9 rnlA== X-Gm-Message-State: AOAM530JzjvGimSwqoVQRfCt9YC1hVce+8GYIII5lG2S0Xyon32mFpS2 fl7qR1tzHHv1DFDbu0R0UpTC9z3vCM2IlZ+NbixLsg== X-Google-Smtp-Source: ABdhPJw/IP2R1Aq/4o4V7xWNzMR1dj0sDA72/sK4bSxYRzT7axA0Lc4WffC5PI4iDX+C5RrdN7SMKaIkyu67l3nbUS8= X-Received: by 2002:a67:c383:: with SMTP id s3mr512619vsj.61.1642871846948; Sat, 22 Jan 2022 09:17:26 -0800 (PST) MIME-Version: 1.0 References: <20211119202408.1815506-1-sjg@chromium.org> <20211119202408.1815506-18-sjg@chromium.org> <20220122132611.schnplwxozqzd7ys@pali> In-Reply-To: <20220122132611.schnplwxozqzd7ys@pali> From: Simon Glass Date: Sat, 22 Jan 2022 10:17:12 -0700 Message-ID: Subject: Re: [PATCH 17/23] video: Convert CONFIG_VIDEO_LOGO to Kconfig To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: U-Boot Mailing List , Anatolij Gustschin , Tom Rini , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Stefan Roese , Stefano Babic Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Pali, On Sat, 22 Jan 2022 at 06:26, Pali Roh=C3=A1r wrote: > > On Friday 19 November 2021 13:24:01 Simon Glass wrote: > > This converts the following to Kconfig: > > CONFIG_VIDEO_LOGO > > > > Note that this option depends on CONFIG_DM_VIDEO now, since cfb_console= is > > deprecated. The only relevant code is now in splash.c > > > > Drop the check for DM_VIDEO in that file. > > > > Signed-off-by: Simon Glass > > --- > ... > > include/configs/nokia_rx51.h | 1 - > ... > > diff --git a/include/configs/nokia_rx51.h b/include/configs/nokia_rx51.= h > > index b37e05406e9..afb91d96a54 100644 > > --- a/include/configs/nokia_rx51.h > > +++ b/include/configs/nokia_rx51.h > > @@ -75,7 +75,6 @@ > > * Framebuffer > > */ > > /* Video console */ > > -#define CONFIG_VIDEO_LOGO > > #define VIDEO_FB_16BPP_PIXEL_SWAP > > #define VIDEO_FB_16BPP_WORD_SWAP > > Hello! > > This change is now in master branch and it broke support for video logo > on Nokia N900 :-( It does not work anymore and reason is because > CONFIG_VIDEO_LOGO was removed from Nokia N900 config files completely, > despite commit subject says CONFIG_VIDEO_LOGO was converted to Kconfig. > > Seems that conversion for Nokia N900 is missing. Could you please look > at this issue? It is visible also in qemu, so no real hardware is needed > for reproducing it. I believe this is because you need to move to DM_VIDEO. Everything else has, I believe, which is why the migration messages have been dropped. +Anatolij Gustschin is looking at removing lcd.c and cfb_console.c I think? Regards, Simon