From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Tue, 11 Jun 2013 13:02:56 -0700
Subject: [U-Boot] [PATCH v2 17/21] arm: Implement the 'fake' go command
In-Reply-To: <20130611215956.2beaec78@lilith>
References: <1370974493-21822-1-git-send-email-sjg@chromium.org>
	<1370974493-21822-18-git-send-email-sjg@chromium.org>
	<20130611215956.2beaec78@lilith>
Message-ID: <CAPnjgZ2Lx_Vb+rnb-14_U5t8nVgfjgOMBrH+pbKKeSOd+i+wvQ@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Albert,

On Tue, Jun 11, 2013 at 12:59 PM, Albert ARIBAUD
<albert.u.boot@aribaud.net>wrote:

> Hi Simon,
>
> On Tue, 11 Jun 2013 11:14:49 -0700, Simon Glass <sjg@chromium.org>
> wrote:
>
> > Implement this feature on ARM for tracing.
> >
> > It would be nice to have generic bootm support so that it is easily
> > implemented on any arch.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> > Changes in v2: None
> >
> >  arch/arm/lib/bootm.c | 33 +++++++++++++++++++++------------
> >  1 file changed, 21 insertions(+), 12 deletions(-)
> >
> > diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
> > index 1b6e0ac..28fba19 100644
> > --- a/arch/arm/lib/bootm.c
> > +++ b/arch/arm/lib/bootm.c
>
> > @@ -225,14 +232,15 @@ static void boot_prep_linux(bootm_headers_t
> *images)
> >  }
> >
> >  /* Subcommand: GO */
> > -static void boot_jump_linux(bootm_headers_t *images)
> > +static void boot_jump_linux(bootm_headers_t *image, int flag)
>
> What's the rationale of the s/images/image/ ?
>

Just that the function only accesses a single image, so I felt it was a
misnomer.

Regards,
Simon


>
> Amicalement,
> --
> Albert.
>