From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A73F2C433EF for ; Tue, 26 Oct 2021 01:28:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFD5461039 for ; Tue, 26 Oct 2021 01:28:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EFD5461039 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA31D832CD; Tue, 26 Oct 2021 03:28:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="M9bOw5wV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D078D80F1A; Tue, 26 Oct 2021 03:28:38 +0200 (CEST) Received: from mail-ua1-x936.google.com (mail-ua1-x936.google.com [IPv6:2607:f8b0:4864:20::936]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 083A780607 for ; Tue, 26 Oct 2021 03:28:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x936.google.com with SMTP id u9so15977355uac.8 for ; Mon, 25 Oct 2021 18:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XixwjDJGhMRgtIInajcnhXjIXVvPgXcCHeZXsCCm0VI=; b=M9bOw5wVCZLXO+tAFn9rPH0K3ja4glrXexYnkr773IgtzqJJK1Ir8JbYZDmQC7IQSe Y/P6qZD11YOxq8bImIZRAC8lS6YK7k3r0nPEeLCq5aHidvjeBDF1v0bY2HzzfBhwb/7E UsQdysNPp2XO6UUtUUUosI8CJ8abv6Fc87XYE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XixwjDJGhMRgtIInajcnhXjIXVvPgXcCHeZXsCCm0VI=; b=OMX96to1z3CgjR8HZNCg41m1C3Z7S0wtNc4zJadCKG/JTRpVq3YJBMjYdpfSbUBKnU QB7w4Y3OrCxqc9CWkWaOdn7PCF6XPGaJpxaaqtMWQQlTI172FQX+sl+3kaD8Qt+h/mqn fgwCb0b2XkIsWRPYxaUF3WrQ0Phn8kvwloTKWSSt/c+LwuI+InBllI2693EAG8UI+2Jc dbi5uAsZj+7Sz92eEUpu8SSfgdQIVY1uF+y+rn0RO0V6lwfM1RmPgM/OFQCa1+4LBnIG h82qPs2bl2cpxbO7wqBLKB1PrIXnBwpt5ahBHYCa7N+tVBybiSeuuoB1+gQWyMKR+QFa GGmw== X-Gm-Message-State: AOAM530KiC4bI5CEEkknZi6T+aHWUpCX9xiOOYMuIcWaGJMhkjcMrNfk cF8mjLbIN9VhcCV+LYv5CV6QR5UJnpXI4cx37q30QJeo X-Google-Smtp-Source: ABdhPJzEJ4/RYBXyTN/DPmmS9POKNc5hvzb757b63FoHV6OksT2S6J9QlusOvkxUndlnCMf/Cr4yvuTFF1l8zdz6CQo= X-Received: by 2002:ab0:22d0:: with SMTP id z16mr19491594uam.143.1635211713136; Mon, 25 Oct 2021 18:28:33 -0700 (PDT) MIME-Version: 1.0 References: <20211014184811.482560-1-sjg@chromium.org> In-Reply-To: <20211014184811.482560-1-sjg@chromium.org> From: Simon Glass Date: Mon, 25 Oct 2021 19:28:21 -0600 Message-ID: Subject: Re: [PATCH v3 00/18] pxe: Refactoring to tidy up and prepare for bootflow To: U-Boot Mailing List Cc: Patrice Chotard , Artem Lapkin , Tom Rini , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes , Ramon Fried Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Ramon, On Thu, 14 Oct 2021 at 12:48, Simon Glass wrote: > > This collects together the patches previously sent relating to PXE. > > Firstly, it moves the boot code out of common/ and into a new boot/ > directory. This helps to collect these related files in one place, as > common/ is quite large. > > Secondly, it provides patache so clean up the PXE code and refactor it > into something closer to a module that can be called, teasing apart its > reliance on the command-line interpreter to access filesystems and the > like. Also it now uses function arguments and its own context struct > internally rather than environment variables, which is very hard to > follow. No core functional change is intended. > > Changes in v3: > - Rebase to -master > > Changes in v2: > - Rebase to -next > - Split out from the bootmethod patches > > Simon Glass (18): > Create a new boot/ directory > pxe: Move API comments to the header files > pxe: Use a context pointer > pxe: Move do_getfile() into the context > pxe: Add a userdata field to the context > pxe: Tidy up the is_pxe global > pxe: Move pxe_utils files > pxe: Tidy up some comments in pxe_utils > pxe: Tidy up code style a little in pxe_utils > pxe: Move common parsing coding into pxe_util > pxe: Clean up the use of bootfile > pxe: Drop get_bootfile_path() > lib: Add tests for simple_itoa() > lib: Add a function to convert a string to a hex value > pxe: Return the file size from the getfile() function > pxe: Refactor sysboot to have one helper > doc: Move distro boot doc to rST > pxe: Allow calling the pxe_get logic directly > > Kconfig | 2 + > Makefile | 3 +- > README | 1 + > common/Kconfig.boot => boot/Kconfig | 0 > boot/Makefile | 37 ++ > {common => boot}/android_ab.c | 0 > {common => boot}/boot_fit.c | 0 > {common => boot}/bootm.c | 0 > {common => boot}/bootm_os.c | 0 > {common => boot}/bootretry.c | 0 > {common => boot}/common_fit.c | 0 > {common => boot}/fdt_region.c | 0 > {common => boot}/image-android-dt.c | 0 > {common => boot}/image-android.c | 0 > {common => boot}/image-board.c | 0 > {common => boot}/image-cipher.c | 0 > {common => boot}/image-fdt.c | 0 > {common => boot}/image-fit-sig.c | 0 > {common => boot}/image-fit.c | 0 > {common => boot}/image-host.c | 0 > {common => boot}/image-sig.c | 0 > {common => boot}/image.c | 0 > {cmd => boot}/pxe_utils.c | 512 +++++++++++----------- > cmd/Makefile | 4 +- > cmd/pxe.c | 136 +++--- > cmd/pxe_utils.h | 91 ---- > cmd/sysboot.c | 114 +++-- > common/Kconfig | 2 - > common/Makefile | 22 - > doc/android/boot-image.rst | 2 +- > doc/{README.distro => develop/distro.rst} | 177 ++++---- > doc/develop/index.rst | 1 + > include/pxe_utils.h | 253 +++++++++++ > include/vsprintf.h | 25 +- > lib/vsprintf.c | 20 +- > scripts/Makefile.spl | 4 +- > test/print_ut.c | 41 ++ > tools/Makefile | 18 +- > 38 files changed, 874 insertions(+), 591 deletions(-) > rename common/Kconfig.boot => boot/Kconfig (100%) > create mode 100644 boot/Makefile > rename {common => boot}/android_ab.c (100%) > rename {common => boot}/boot_fit.c (100%) > rename {common => boot}/bootm.c (100%) > rename {common => boot}/bootm_os.c (100%) > rename {common => boot}/bootretry.c (100%) > rename {common => boot}/common_fit.c (100%) > rename {common => boot}/fdt_region.c (100%) > rename {common => boot}/image-android-dt.c (100%) > rename {common => boot}/image-android.c (100%) > rename {common => boot}/image-board.c (100%) > rename {common => boot}/image-cipher.c (100%) > rename {common => boot}/image-fdt.c (100%) > rename {common => boot}/image-fit-sig.c (100%) > rename {common => boot}/image-fit.c (100%) > rename {common => boot}/image-host.c (100%) > rename {common => boot}/image-sig.c (100%) > rename {common => boot}/image.c (100%) > rename {cmd => boot}/pxe_utils.c (74%) > delete mode 100644 cmd/pxe_utils.h > rename doc/{README.distro => develop/distro.rst} (76%) > create mode 100644 include/pxe_utils.h > > -- > 2.33.0.1079.g6e70778dc9-goog > I see this series is assigned to you in patchwork. Did you see it? It looks like you are network maintainer but that doesn't include the PXE files for some reason... Regards, Simon