From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sun, 8 Jan 2012 10:02:59 -0800 Subject: [U-Boot] [PATCH 1/9] usb: Fix strict-aliasing warning in host/ohci-hcd.c In-Reply-To: <201201080432.28463.vapier@gentoo.org> References: <1325822097-15227-1-git-send-email-sjg@chromium.org> <1325822097-15227-2-git-send-email-sjg@chromium.org> <201201080432.28463.vapier@gentoo.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Mike, On Sun, Jan 8, 2012 at 1:32 AM, Mike Frysinger wrote: > On Thursday 05 January 2012 22:54:49 Simon Glass wrote: >> ? ? ? len = min_t(int, len, leni); >> - ? ? if (data != databuf.ptr) >> - ? ? ? ? ? ? memcpy(data, databuf.ptr, len); >> + ? ? if (dataptr) >> + ? ? ? ? ? ? memcpy(data, dataptr, len); >> + ? ? else >> + ? ? ? ? ? ? memcpy(data, &databuf, len); > > this doesn't seem to be equivalent ? > -mike I believe it is if you look at the entire change, but I might have missed something. dataptr is used only when we want to pull in the USB descriptor info. Otherwise we use our local databuf union. Regards, Simon