From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 462F1C61DA4 for ; Mon, 6 Mar 2023 18:10:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A1EBC8595C; Mon, 6 Mar 2023 19:10:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="EX/5VnBl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A770C85CC8; Mon, 6 Mar 2023 18:57:02 +0100 (CET) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A25E085B23 for ; Mon, 6 Mar 2023 18:56:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-yb1-xb2d.google.com with SMTP id y144so9000850yby.12 for ; Mon, 06 Mar 2023 09:56:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1678125231; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CB61ac+P4YzYBc9hpOUJkJ+Y2JrVWgafpPe4gqxqsmc=; b=EX/5VnBlIf+C4a4pxOuoJ0JUG64LnMppwb7iW+IuLHdX21MhIqkj0Bymu7qbuRBHW7 HCuwmhPEBZZKHEeWtGzzeNT+ZrJIDdGbBN9ntWwkHq24mpu9e+cuCaZA2ylhQuX8T1Ey iNPIwla2y+xVISRnL7FMrbvPVW6jc8ZIVa0yk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678125231; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CB61ac+P4YzYBc9hpOUJkJ+Y2JrVWgafpPe4gqxqsmc=; b=RL7KkuWj0xcD+fjL6Hg4XCIRl8vILg6PKJsS42AGRx2ySlnct45fnIRpL0OfUemxtD YZukRjb2dX1+7runUWXUh44M6d5mBBFj/lZ+wfUkex/T/1c378+G7tCeh0HOBNjtb8Vt VM4tw6snFZU6FdlJk6BwnQezzVaRldLB/zuHoGeau9s9DlTn9UkffXznqyXfSBSY8W6z MvVq++AEuRZWXbJdZnTxFy6VojTzggmYq8MTPQBbIIQsEvGiJYfl1Go2GkCNLpEQ39/u yp1rSS+DIUmeuIQULfdN1YXqMRWoYu8l6DcT15jlALpznuIuVzsAhDGyNUWse642aw7f IciQ== X-Gm-Message-State: AO0yUKU8oQBn0E8him/032wjZ3uEmvLrLySksk5Fl8zcS+Bqr7EWvXf+ LjuL6ysxOblolstnR9IHfkYtUwWZn+ydha56ePHIynh4Ufsq9dP31QE= X-Google-Smtp-Source: AK7set8rCCc2P/OW7YmpRfM8CA9gXRcQqMhwAthWIVPvlQGounnY7TKVpkMgAt1CBmlzYYO+GRzor4mc8/vUdxEufUI= X-Received: by 2002:a05:6902:524:b0:ab8:1ed9:cfc5 with SMTP id y4-20020a056902052400b00ab81ed9cfc5mr6952906ybs.6.1678125230688; Mon, 06 Mar 2023 09:53:50 -0800 (PST) MIME-Version: 1.0 References: <20230222163425.2043934-1-sjg@chromium.org> <20230222163425.2043934-33-sjg@chromium.org> <20230303145023.GA275547@bill-the-cat> In-Reply-To: <20230303145023.GA275547@bill-the-cat> From: Simon Glass Date: Mon, 6 Mar 2023 10:53:15 -0700 Message-ID: Subject: Re: [PATCH v5 32/44] x86: Fix up use of X86_32BIT_INIT and X86_64 options To: Tom Rini Cc: U-Boot Mailing List , Bin Meng Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Fri, 3 Mar 2023 at 07:50, Tom Rini wrote: > > On Wed, Feb 22, 2023 at 09:34:13AM -0700, Simon Glass wrote: > > > Drop the invalid SPL_ in a CONFIG_IS_ENABLED() usage. Use the correct > > X86_64 option in msr.h since SPL may be 32-bit when U-Bout proper is > > not. > > > > Signed-off-by: Simon Glass > > --- > > > > (no changes since v4) > > > > Changes in v4: > > - Reduce and rename commit > > > > arch/x86/cpu/qemu/qemu.c | 2 +- > > arch/x86/include/asm/msr.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > This changes spl on chromebook_link64 a lot, have you confirmed it > there? No, the lab is broken...will do at some point. Regards, Simon